This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Dedupe onError and ensure refetch sets loading state properly
#3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. It prevents the `onError` callback from unnecessarily being called multiple times in a row. 2. It migrates all peer and dev deps to use `apollo-client` 2.6.4. Apollo Client 2.6.4 provides a fix for last result error tracking (apollographql/apollo-client@c44e821), which fixes the long standing React Apollo issue of `refetch` not setting `loading` state properly. Calling `refetch` will now first set `loading` to `true`. These fixes are bundled together, as verifying that `onError` is working properly requires being able to make sure results after a refetch that don't have an error, are handled properly. Fixes #3331. Fixes #3287. Fixes #2559. Fixes #321. (and probably fixes others!)
This was referenced Aug 13, 2019
hwillson
added a commit
that referenced
this pull request
Aug 13, 2019
…3362) * Add test to verify error is persisted on re-render, when appropriate Issue #3295 demonstrates a problem where errors aren't maintained on re-renders, when they should still be available. This issue was fixed by PR #3339, but this commit will add an extra test to verify that the issue is indeed fixed. Fixes #3295. * Changelog update
This was referenced Aug 23, 2019
Closed
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit helps address 2 main issues:
onErrorcallback from unnecessarily being called multiple times in a row.apollo-client2.6.4. Apollo Client 2.6.4 provides a fix for last result error tracking (apollographql/apollo-client@c44e821), which fixes the long standing React Apollo issue ofrefetchnot settingloadingstate properly. Callingrefetchwill now first setloadingtotrue.These fixes are bundled together, as verifying that
onErroris working properly requires being able to make sure results after a refetch that don't have an error, are handled properly.Fixes #3331.
Fixes #3287.
Fixes #2559.
Fixes #321.
(and probably others!)