Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Dedupe onError and ensure refetch sets loading state properly #3339

Merged
merged 3 commits into from Aug 10, 2019
Merged

Dedupe onError and ensure refetch sets loading state properly #3339

merged 3 commits into from Aug 10, 2019

Commits on Aug 10, 2019

  1. This commit helps address 2 main issues: 

    1. It prevents the `onError` callback from unnecessarily being
called multiple times in a row.

2. It migrates all peer and dev deps to use `apollo-client`
2.6.4. Apollo Client 2.6.4 provides a fix for last result
error tracking
(apollographql/apollo-client@c44e821),
which fixes the long standing React Apollo issue of `refetch`
not setting `loading` state properly. Calling `refetch` will
now first set `loading` to `true`.

These fixes are bundled together, as verifying that `onError`
is working properly requires being able to make sure results
after a refetch that don't have an error, are handled properly.

Fixes #3331.
Fixes #3287.
Fixes #2559.
Fixes #321.

(and probably fixes others!)
    @hwillson
    hwillson committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    6eae158 View commit details
    Browse the repository at this point in the history

  2. Changelog update

    @hwillson
    hwillson committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    6e81220 View commit details
    Browse the repository at this point in the history

  3. Silence extra CI warnings to troubleshoot test issues

    @hwillson
    hwillson committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    be122f0 View commit details
    Browse the repository at this point in the history