BTS-1868: fix TSan errors

[jsteemann]

Scope & Purpose

Enterprise companion PR: https://github.com/arangodb/enterprise/pull/1484

BTS-1868: fix TSan errors
https://arangodb.atlassian.net/browse/BTS-1868

This PR makes 2 relevant changes:

• NetworkFeature now shuts down retry requests also in its destructor. Previously retry requests were only shut down in stop() and unprepare(), but if these were not called, retry requests could leak.
• AuthenticationFeature::INSTANCE was a raw pointer and was accessed and modified without synchronization. This PR turns it into an atomic pointer, so that TSan does not report data races when the member is accessed.

As this PR also removes some includes from central header files and replaces them by forward definitions, a lot of unrelated files also had to be changed so that the previously transitively included header files would be included there.

• 💩 Bugfix
• 🍕 New feature
• 🔥 Performance improvement
• 🔨 Refactoring/simplification

Checklist

• Tests
  • Regression tests
  • C++ Unit tests
  • integration tests
  • resilience tests
• 📖 CHANGELOG entry made
• 📚 documentation written (release notes, API changes, ...)
• Backports
  • Backport for 3.12.0: -
  • Backport for 3.11: -
  • Backport for 3.10: -

Related Information

• Docs PR:
• Enterprise PR: https://github.com/arangodb/enterprise/pull/1484
• GitHub issue / Jira ticket: https://arangodb.atlassian.net/browse/BTS-1868
• Design document:

[neunhoef]

LGTM