Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hash fragments, which are more private #21

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

rmsy
Copy link

@rmsy rmsy commented Nov 29, 2023

Hey there! 馃憢 Thanks so much for creating this app! 馃槃 It's a great little tool for organizing my friends' Secret Santa exchange, and way better than forking over personal data to all of the wacky sites you'll find on Google.

This tool is almost perfect in my eyes, but in the name of bolstering user privacy even more, I'm submitting this PR -- the reason being, hash fragments are more secure than search parameters for transmitting data to another user when said data doesn't require processing on the server (because hash fragments are never transmitted to the server in the first place).

This means that the key and encrypted data never leaves the user's browser. Now, do I think GitHub is digging through GitHub Pages request logs to look through this information? No, but they could -- and so could the users' ISPs, or Internet cafes, or malicious users at said Internet cafes (because the site does not require HTTPS; please enable that, it's just one click!).

It's a small change, and it functions identically to the current version, but it doesn't result in sending users' sensitive data over the internet 馃槉 (this matters less for IRL Secret Santas, but I'm using this with some online friends, and want to be sensitive with their addresses, which will be included as part of the "extra info" in the app).

Thanks so much for your time!

They prevent user data from leaving the browser.
@arcanis
Copy link
Owner

arcanis commented Dec 4, 2023

Thanks, I like the idea ! One thing however is that it needs to support both query string and hashes - we don't want to break the secret santa pages from everyone who already generated their pairings 馃榾

@rmsy
Copy link
Author

rmsy commented Dec 4, 2023

Ah, good point! Totally neglected to consider that. I'll update the PR later tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants