Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #1102

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 19 additions & 17 deletions src/test/testMakeRemoteExecutableSchema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@ describe('remote subscriptions', () => {
`);

let notificationCnt = 0;
subscribe(schema, subscription).then(results =>
subscribe(schema, subscription).then(results => {
forAwaitEach(results as AsyncIterable<ExecutionResult>, (result: ExecutionResult) => {
expect(result).to.have.property('data');
expect(result.data).to.deep.equal(mockNotification);
!notificationCnt++ ? done() : null;
}),
);

subscriptionPubSub.publish(subscriptionPubSubTrigger, mockNotification);
});
}).then(() => {
subscriptionPubSub.publish(subscriptionPubSubTrigger, mockNotification);
});
});

it('should work without triggering multiple times per notification', done => {
Expand All @@ -59,27 +59,29 @@ describe('remote subscriptions', () => {
`);

let notificationCnt = 0;
subscribe(schema, subscription).then(results =>
const sub1 = subscribe(schema, subscription).then(results => {
forAwaitEach(results as AsyncIterable<ExecutionResult>, (result: ExecutionResult) => {
expect(result).to.have.property('data');
expect(result.data).to.deep.equal(mockNotification);
notificationCnt++;
}),
);
});
});

subscribe(schema, subscription).then(results =>
const sub2 = subscribe(schema, subscription).then(results => {
forAwaitEach(results as AsyncIterable<ExecutionResult>, (result: ExecutionResult) => {
expect(result).to.have.property('data');
expect(result.data).to.deep.equal(mockNotification);
}),
);
});
});

subscriptionPubSub.publish(subscriptionPubSubTrigger, mockNotification);
subscriptionPubSub.publish(subscriptionPubSubTrigger, mockNotification);
Promise.all([sub1, sub2]).then(() => {
subscriptionPubSub.publish(subscriptionPubSubTrigger, mockNotification);
subscriptionPubSub.publish(subscriptionPubSubTrigger, mockNotification);

setTimeout(() => {
expect(notificationCnt).to.eq(2);
done();
}, 0);
setTimeout(() => {
expect(notificationCnt).to.eq(2);
done();
}, 0);
});
});
});
14 changes: 6 additions & 8 deletions src/test/testMergeSchemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -736,10 +736,9 @@ bookingById(id: "b1") {
!notificationCnt++ ? done() : null;
},
).catch(done);
})
.catch(done);

subscriptionPubSub.publish(subscriptionPubSubTrigger, mockNotification);
}).then(() => {
subscriptionPubSub.publish(subscriptionPubSubTrigger, mockNotification);
}).catch(done);
});

it('subscription errors are working correctly in merged schema', done => {
Expand Down Expand Up @@ -793,10 +792,9 @@ bookingById(id: "b1") {
!notificationCnt++ ? done() : null;
},
).catch(done);
})
.catch(done);

subscriptionPubSub.publish(subscriptionPubSubTrigger, mockNotification);
}).then(() => {
subscriptionPubSub.publish(subscriptionPubSubTrigger, mockNotification);
}).catch(done);
});

it('links in queries', async () => {
Expand Down
6 changes: 3 additions & 3 deletions src/test/testResolution.ts
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,11 @@ describe('Resolve', () => {
done(new Error('Too many subscription fired'));
},
).catch(done);
})
.catch(done);
}).then(() => {
pubsub.publish('printRootChannel', { printRoot: subscriptionRoot });
}).catch(done);
});

pubsub.publish('printRootChannel', { printRoot: subscriptionRoot });

firstSubsTriggered
.then(() =>
Expand Down