Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #1102

Closed
wants to merge 5 commits into from
Closed

Fix tests #1102

wants to merge 5 commits into from

Conversation

yaacovCR
Copy link
Collaborator

@yaacovCR yaacovCR commented Apr 14, 2019

graphql 1.1.0 only adds listeners after first call to next(), see apollographql/graphql-subscriptions#148.

  • NA: If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • NA: Update CHANGELOG.md with your change. Include a description of your change, link to PR (always) and issue (if applicable). Add your CHANGELOG entry under vNEXT. Do not create a new version number for your change yourself.

graphql 1.1.0 only adds listeners after first call to next(), see apollographql/graphql-subscriptions#148
@apollo-cla
Copy link

@yaacovCR: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

fix ;
@yaacovCR
Copy link
Collaborator Author

Closing in favor of #1206

@yaacovCR yaacovCR closed this Sep 24, 2019
@yaacovCR yaacovCR deleted the fixtests branch September 24, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants