chore(deps)!: bump openapi-generator-cli in python sdk client to 7.4.0
#12866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YatinGupta777
force-pushed
the
update-openapi-gen
branch
3 times, most recently
from
f6b6dfc
to
b9a88dc
Compare
Signed-off-by: Yatin Gupta <yatingupta7777@gmail.com>
YatinGupta777
force-pushed
the
update-openapi-gen
branch
from
b9a88dc
to
e20875d
Compare
blkperl
added
the
type/dependencies
agilgur5
changed the title
agilgur5
changed the title
openapi-generator-cli in python sdk client to 7.4.0
| @@ -30,7 +30,7 @@ else | |||
| sed 's/io.k8s.apimachinery.pkg.apis.meta.v1.//' \ | |||
| > $(WD)/swagger.json | |||
| cp ../../LICENSE $(WD)/LICENSE | |||
| $(DOCKER) openapitools/openapi-generator-cli:v5.4.0 \ | |||
| $(DOCKER) openapitools/openapi-generator-cli:v7.4.0 \ | |||
There was a problem hiding this comment.
I think this was pinned to this version for a reason. Have you tested the generated SDK?
There was a problem hiding this comment.
Havent tested it yet but the sdk unit test is failing so I think the interface has changed. Do you remember the reason for the specific version pinning? Or is there some specific testing that would need to be done?
|
We should probably hold off on this and start migrating to Hera. cc @flaviuvadan |
This reverts commit 70e1965.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Python SDK has been using open api generator 5.4.0 which is 2 years old.
Modifications
Upgraded to latest open api version 7.4.0 which was closed 3 weeks ago https://github.com/OpenAPITools/openapi-generator/milestones?state=closed
Verification