Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps)!: bump openapi-generator-cli in python sdk client to 7.4.0 #12866

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

chore(deps)!: bump openapi-generator-cli in python sdk client to 7.4.0 #12866

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e20875d
chore(deps): Update open api generator in python sdk client to 7.4.0
YatinGupta777 Apr 1, 2024
70e1965
Fix python sdk test by importing from models instead of model
YatinGupta777 Apr 1, 2024
f7c8f00
Merge branch 'main' into update-openapi-gen
YatinGupta777 May 9, 2024
9fbf629
Revert "Fix python sdk test by importing from models instead of model"
YatinGupta777 May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion sdks/python/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ else
sed 's/io.k8s.apimachinery.pkg.apis.meta.v1.//' \
> $(WD)/swagger.json
cp ../../LICENSE $(WD)/LICENSE
$(DOCKER) openapitools/openapi-generator-cli:v5.4.0 \
$(DOCKER) openapitools/openapi-generator-cli:v7.4.0 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was pinned to this version for a reason. Have you tested the generated SDK?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Havent tested it yet but the sdk unit test is failing so I think the interface has changed. Do you remember the reason for the specific version pinning? Or is there some specific testing that would need to be done?

generate \
--input-spec /wd/swagger.json \
--generator-name python \
Expand Down
425 changes: 417 additions & 8 deletions sdks/python/client/argo_workflows/__init__.py
View file
Open in desktop

Large diffs are not rendered by default.

17 changes: 14 additions & 3 deletions sdks/python/client/argo_workflows/api/__init__.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.