fix(ui): show container logs when using templateRef
#12973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be backported to 3.4.x as well, since the bug has been around for a while |
- the component was incorrectly assuming that `node.templateName` exists, which it doesn't in the case of a `templateRef` - use the existing `getTemplateNameFromNode` function to properly handle that instead Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
- it breaks on build and lint, but `git` wouldn't detect it as it's not part of the diff Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
force-pushed
the
fix-ui-log-viewer-templateRef
branch
from
71f4f51
to
dc40905
Compare
|
This explains why I'm not seeing anything when viewing all logs. |
This makes you able to use the template combobox in the logs viewer per #9938, to clarify. Not sure if that's what you meant. |
|
It is. |
tczhao
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9938
Related to #12970 -- that's for the back-end, this is the one remaining place in the front-end
Motivation
node.templateNameexists, which it doesn't in the case of atemplateRefModifications
getTemplateNameFromNodefunction to properly handle that insteadVerification
Used the WorkflowTemplate and Workflow from the issue repro, can see all containers and logs.
Screenshot: