Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): show container logs when using templateRef #12973

Merged
merged 3 commits into from
May 22, 2024
Merged

fix(ui): show container logs when using templateRef #12973

merged 3 commits into from
May 22, 2024

Commits on Apr 24, 2024

  1. fix(ui): show container logs when using templateRef 

    - the component was incorrectly assuming that `node.templateName` exists, which it doesn't in the case of a `templateRef`
  - use the existing `getTemplateNameFromNode` function to properly handle that instead

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
    @agilgur5
    agilgur5 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    99d0251 View commit details
    Browse the repository at this point in the history

  2. fix invisible merge conflict 

    - it breaks on build and lint, but `git` wouldn't detect it as it's not part of the diff

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
    @agilgur5
    agilgur5 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    dc40905 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge branch 'main' into fix-ui-log-viewer-templateRef

    @agilgur5
    agilgur5 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    cadedf5 View commit details
    Browse the repository at this point in the history