Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test modules #2874

Merged
merged 14 commits into from
Dec 28, 2022
Merged

Remove test modules #2874

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
244d5fa
First step in removing `arrow-core-test`
serras Dec 22, 2022
454b231
Remove `arrow-optics-test`
serras Dec 22, 2022
32376a5
Remove all test modules from Gradle
serras Dec 22, 2022
d5d6000
Finish removing `test` module from `arrow-fx-coroutines`
serras Dec 22, 2022
bc7dde9
Remove test from `arrow-core-retrofit`
serras Dec 22, 2022
f6128c8
Keep removing things
serras Dec 23, 2022
ba1bcea
Use Mocha for browser tests
serras Dec 23, 2022
0e1505d
Longer timeout for Ubuntu
serras Dec 28, 2022
172eb7f
Revert using Mocha for tests
serras Dec 28, 2022
57a6568
Separate tests into different targets for Ubuntu
serras Dec 28, 2022
41c8483
Fix bugs in JS
serras Dec 28, 2022
ae94041
Remove KSP from Kover
serras Dec 28, 2022
18f8f4c
Update Kover
serras Dec 28, 2022
8b9c8ca
--info for JS tests
serras Dec 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion arrow-libs/core/arrow-continuations/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ kotlin {
if(!enableCompatibilityMetadataVariant) {
commonTest {
dependencies {
implementation(project(":arrow-core-test"))
implementation(projects.arrowCore)
implementation(libs.kotest.frameworkEngine)
implementation(libs.kotest.assertionsCore)
implementation(libs.kotest.property)
}
}
jvmTest {
Expand Down
5 changes: 3 additions & 2 deletions ...-libs/core/arrow-continuations/src/commonTest/kotlin/generic/SuspendingComputationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,15 @@ import arrow.core.computations.ensureNotNull
import arrow.core.computations.eval
import arrow.core.left
import arrow.core.right
import arrow.core.test.UnitSpec
import io.kotest.assertions.fail
import io.kotest.core.spec.style.StringSpec
import io.kotest.matchers.shouldBe
import io.kotest.property.Arb
import io.kotest.property.arbitrary.boolean
import io.kotest.property.arbitrary.int
import io.kotest.property.arbitrary.orNull
import io.kotest.property.arbitrary.string
import io.kotest.property.checkAll
import kotlinx.coroutines.CompletableDeferred
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Deferred
Expand All @@ -31,7 +32,7 @@ import kotlin.coroutines.intrinsics.intercepted
import kotlin.coroutines.intrinsics.suspendCoroutineUninterceptedOrReturn
import kotlin.coroutines.startCoroutine

class SuspendingComputationTest : UnitSpec({
class SuspendingComputationTest : StringSpec({

"immediate values" {
either<String, Int> {
Expand Down
5 changes: 4 additions & 1 deletion arrow-libs/core/arrow-core-retrofit/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,12 @@ dependencies {
compileOnly(libs.squareup.retrofit)

if (!enableCompatibilityMetadataVariant) {
testImplementation(projects.arrowCore)
testImplementation(libs.kotest.frameworkEngine)
testImplementation(libs.kotest.assertionsCore)
testImplementation(libs.kotest.property)
testCompileOnly(libs.kotlin.reflect)
testRuntimeOnly(libs.kotest.runnerJUnit5)
testImplementation(project(":arrow-core-test"))
testImplementation(libs.squareup.okhttpMockWebServer)
testImplementation(libs.squareup.retrofitConverterGson)
testImplementation(libs.squareup.retrofitConverterMoshi)
Expand Down
14 changes: 6 additions & 8 deletions ...core-retrofit/src/test/kotlin/arrow/retrofit/adapter/either/ArrowEitherCallAdapterTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,21 @@ package arrow.retrofit.adapter.either

import arrow.core.left
import arrow.core.right
import arrow.core.test.UnitSpec
import arrow.retrofit.adapter.mock.ErrorMock
import arrow.retrofit.adapter.mock.ResponseMock
import arrow.retrofit.adapter.retrofit.SuspendApiTestClient
import io.kotest.core.spec.style.StringSpec
import io.kotest.matchers.shouldBe
import okhttp3.mockwebserver.MockResponse
import okhttp3.mockwebserver.MockWebServer
import okhttp3.mockwebserver.SocketPolicy
import retrofit2.Retrofit
import retrofit2.converter.gson.GsonConverterFactory

class ArrowEitherCallAdapterTest : UnitSpec() {
class ArrowEitherCallAdapterTest : StringSpec({

private lateinit var server: MockWebServer
private lateinit var service: SuspendApiTestClient

init {
lateinit var server: MockWebServer
lateinit var service: SuspendApiTestClient

beforeAny {
server = MockWebServer()
Expand Down Expand Up @@ -88,5 +86,5 @@ class ArrowEitherCallAdapterTest : UnitSpec() {

body.isFailure shouldBe true
}
}
}

})
14 changes: 6 additions & 8 deletions ...-core-retrofit/src/test/kotlin/arrow/retrofit/adapter/either/ArrowResponseEAdapterTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,21 @@ package arrow.retrofit.adapter.either

import arrow.core.left
import arrow.core.right
import arrow.core.test.UnitSpec
import arrow.retrofit.adapter.mock.ErrorMock
import arrow.retrofit.adapter.mock.ResponseMock
import arrow.retrofit.adapter.retrofit.SuspendApiTestClient
import io.kotest.core.spec.style.StringSpec
import io.kotest.matchers.shouldBe
import okhttp3.mockwebserver.MockResponse
import okhttp3.mockwebserver.MockWebServer
import okhttp3.mockwebserver.SocketPolicy
import retrofit2.Retrofit
import retrofit2.converter.gson.GsonConverterFactory

class ArrowResponseEAdapterTest : UnitSpec() {
class ArrowResponseEAdapterTest : StringSpec({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally StringSpec({ }) everywhere ❤️


private lateinit var server: MockWebServer
private lateinit var service: SuspendApiTestClient

init {
lateinit var server: MockWebServer
lateinit var service: SuspendApiTestClient

beforeAny {
server = MockWebServer()
Expand Down Expand Up @@ -100,5 +98,5 @@ class ArrowResponseEAdapterTest : UnitSpec() {

responseE.isFailure shouldBe true
}
}
}

})
158 changes: 0 additions & 158 deletions arrow-libs/core/arrow-core-test/api/arrow-core-test.api
View file
Open in desktop

This file was deleted.

37 changes: 0 additions & 37 deletions arrow-libs/core/arrow-core-test/build.gradle.kts
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions arrow-libs/core/arrow-core-test/gradle.properties
View file
Open in desktop

This file was deleted.