Remove `test` modules #2874

serras · 2022-12-22T09:10:45Z

In one of the last meetings we agreed on removing the three test modules for Arrow, and depend directly on Kotest as much as possible. The generators and other small things should move to commonTest in their corresponding projects, to make them self-contained.

serras · 2022-12-22T19:57:36Z

I've decided not to apply ktlint to the files in order to minimize the diff. However, that means that indentation is a bit weird, because in some cases there's one fewer brace, but no change in indentation. If you think I should apply linting, I'm happy to do it.

JavierSegoviaCordoba · 2022-12-22T22:41:01Z

As ktfmt resolved the knit issue maybe we should re-add it in a different pull request, cc @nomisRev.

raulraja

thanks @serras !

raulraja · 2022-12-23T09:45:45Z

arrow-libs/core/arrow-core/src/commonTest/kotlin/arrow/core/OptionTest.kt

@@ -54,9 +54,8 @@ class OptionTest : UnitSpec() {
      fun square(i: Int): Int = i * i
      checkAll(Arb.int().orNull()) { i: Int? ->
        option {
-          val ii = i


When the debugger does not capture i in the lambda scope tricks... xD

raulraja · 2022-12-23T09:48:38Z

arrow-libs/core/arrow-core/src/commonTest/kotlin/arrow/core/test/Generators.kt

+import kotlin.coroutines.intrinsics.suspendCoroutineUninterceptedOrReturn
+import kotlin.coroutines.startCoroutine
+
+// copied from kotest-extensions-arrow


Are we doing this to avoid having kotest-extensions-arrow in the classpath? If so, we can manually exclude the arrow version that brings in the build file to avoid implementing this on our own.

We were doing this in 2.x.x branch, which resulted in breaking changes. So simply excluding version doesn't work due to binary incompat. We decided to do this in 1.x.x, and merge it that way to 2.x.x

There's some work on that line in other PR, but it never worked due to the breaking changes in the dependencies.

raulraja · 2022-12-23T09:57:23Z

arrow-libs/core/arrow-core/src/commonTest/kotlin/arrow/core/test/Platform.kt

+import io.kotest.common.platform
+
+fun stackSafeIteration(): Int = when (platform) {
+  Platform.JVM -> 500_000


These values seem arbitrary. For reference, we have something similar in the andThen composition where we use other concerns to calculate when to jump off stack https://github.com/arrow-kt/arrow/blob/0afdd9a7cc5251cf0c50701b21ccbb5693045bde/arrow-libs/core/arrow-core/src/jvmMain/kotlin/arrow/core/composition-jvm.kt Not sure if relevant where this is used but thought I'd mention it.

Maybe what we have in andThen is no longer relevant.

I just took it from the arrow-core-test, I'm not sure where this come from or whether it's still relevant.

nomisRev · 2022-12-23T12:45:41Z

Yes, we should re-add it and run it over the codebase @JavierSegoviaCordoba. Feel free to create a PR for it if you have some time in the next weeks.

nomisRev

Looks great to me @serras! Thanks 🙏
Wondering if we need to keep publishing the -test modules until their removal in 2.x.x or tell people to switch to Kotest modules instead and stop publishing 🤔

nomisRev · 2022-12-23T12:46:26Z

...row-core-retrofit/src/test/kotlin/arrow/retrofit/adapter/either/ArrowResponseEAdapterTest.kt

 import io.kotest.matchers.shouldBe
 import okhttp3.mockwebserver.MockResponse
 import okhttp3.mockwebserver.MockWebServer
 import okhttp3.mockwebserver.SocketPolicy
 import retrofit2.Retrofit
 import retrofit2.converter.gson.GsonConverterFactory

-class ArrowResponseEAdapterTest : UnitSpec() {
+class ArrowResponseEAdapterTest : StringSpec({


Finally StringSpec({ }) everywhere ❤️

nomisRev · 2022-12-23T12:54:05Z

arrow-libs/core/arrow-core/src/commonTest/kotlin/arrow/core/test/Generators.kt

+import kotlin.coroutines.intrinsics.suspendCoroutineUninterceptedOrReturn
+import kotlin.coroutines.startCoroutine
+
+// copied from kotest-extensions-arrow


We were doing this in 2.x.x branch, which resulted in breaking changes. So simply excluding version doesn't work due to binary incompat. We decided to do this in 1.x.x, and merge it that way to 2.x.x

serras · 2022-12-28T16:15:31Z

arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/CountDownLatch.kt

@@ -25,7 +25,11 @@ public class CountDownLatch(private val initial: Long) {
  public fun count(): Long = count.get()

  /** Await [count] to reach zero */
-  public suspend fun await(): Unit = signal.await()
+  public suspend fun await(): Unit =


@nomisRev I had to change this method because it was failing in JS. It seems that CompletableDeferred doesn't work correctly on that platform :(

github-actions · 2022-12-28T19:01:35Z

Kover Report

File	Coverage [50.00%]
arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/CountDownLatch.kt	94.44%
arrow-libs/fx/arrow-fx-coroutines/src/commonTest/kotlin/arrow/fx/coroutines/Platform.kt	10.00%

Total Project Coverage	40.29%

First step in removing arrow-core-test

244d5fa

serras requested a review from a team December 22, 2022 09:10

serras added 4 commits December 22, 2022 12:06

Remove arrow-optics-test

454b231

Remove all test modules from Gradle

32376a5

Finish removing test module from arrow-fx-coroutines

d5d6000

Remove test from arrow-core-retrofit

bc7dde9

serras marked this pull request as ready for review December 22, 2022 19:56

Keep removing things

f6128c8

raulraja approved these changes Dec 23, 2022

View reviewed changes

nomisRev reviewed Dec 23, 2022

View reviewed changes

nomisRev approved these changes Dec 23, 2022

View reviewed changes

serras added 5 commits December 23, 2022 20:48

Use Mocha for browser tests

ba1bcea

Longer timeout for Ubuntu

0e1505d

Revert using Mocha for tests

172eb7f

Separate tests into different targets for Ubuntu

57a6568

Fix bugs in JS

41c8483

serras commented Dec 28, 2022

View reviewed changes

serras added 2 commits December 28, 2022 17:56

Remove KSP from Kover

ae94041

Update Kover

18f8f4c

--info for JS tests

8b9c8ca

serras merged commit 7a08939 into main Dec 28, 2022

serras deleted the as-remove-test branch December 28, 2022 21:02

serras mentioned this pull request Dec 29, 2022

Arrow 2.0 #2778

Merged

20 tasks

nomisRev mentioned this pull request Jan 25, 2023

Github Actions improvements, Revert karma config, and add KotestProjectConfig #2904

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `test` modules #2874

Remove `test` modules #2874

serras commented Dec 22, 2022

serras commented Dec 22, 2022

JavierSegoviaCordoba commented Dec 22, 2022

raulraja left a comment

raulraja Dec 23, 2022

raulraja Dec 23, 2022

nomisRev Dec 23, 2022

serras Dec 23, 2022

raulraja Dec 23, 2022 •

edited

serras Dec 23, 2022

nomisRev commented Dec 23, 2022

nomisRev left a comment

nomisRev Dec 23, 2022

nomisRev Dec 23, 2022

serras Dec 28, 2022 •

edited

github-actions bot commented Dec 28, 2022 •

edited

Remove test modules #2874

Remove test modules #2874

Conversation

serras commented Dec 22, 2022

serras commented Dec 22, 2022

JavierSegoviaCordoba commented Dec 22, 2022

raulraja left a comment

Choose a reason for hiding this comment

raulraja Dec 23, 2022

Choose a reason for hiding this comment

raulraja Dec 23, 2022

Choose a reason for hiding this comment

nomisRev Dec 23, 2022

Choose a reason for hiding this comment

serras Dec 23, 2022

Choose a reason for hiding this comment

raulraja Dec 23, 2022 • edited

Choose a reason for hiding this comment

serras Dec 23, 2022

Choose a reason for hiding this comment

nomisRev commented Dec 23, 2022

nomisRev left a comment

Choose a reason for hiding this comment

nomisRev Dec 23, 2022

Choose a reason for hiding this comment

nomisRev Dec 23, 2022

Choose a reason for hiding this comment

serras Dec 28, 2022 • edited

Choose a reason for hiding this comment

github-actions bot commented Dec 28, 2022 • edited

Kover Report

Remove `test` modules #2874

Remove `test` modules #2874

raulraja Dec 23, 2022 •

edited

serras Dec 28, 2022 •

edited

github-actions bot commented Dec 28, 2022 •

edited