fix(qwik): don't externalise @unpic/core dep
#254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unpic-svelte ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-solid ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-vue ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-qwik ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-webc ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-preact canceled.
|
✅ Deploy Preview for unpic-angular ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-docs canceled.
|
✅ Deploy Preview for unpic-next ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-lit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-astro ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Merged
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 19, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>qwik: 0.0.20</summary> ## [0.0.20](qwik-v0.0.19...qwik-v0.0.20) (2023-06-19) ### Bug Fixes * **qwik:** don't externalise `@unpic/core` dep ([#254](#254)) ([089245b](089245b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why, but when installed with pnpm, rollup is unable to resolve the
@unpic/coretransitive dependency. This PR moves the package out of external deps, so that it is compiled into the bundle. Fixes #69