fix bug when rewriting deprecated unittest functions #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Sep 21, 2023
Comment on lines
59
to
62
| isinstance(node.func, ast.Attribute) and | ||
| isinstance(node.func.value, ast.Name) and | ||
| node.func.value.id == 'unittest' and | ||
| node.func.attr in FUNCTION_MAPPING |
There was a problem hiding this comment.
don't touch unrelated code to imbue your style on it
There was a problem hiding this comment.
oops, left formatter settings on, sorry
asottile
reviewed
Sep 21, 2023
Comment on lines
19
to
20
| ('unittest.makeSuite(Tests, "arg")',), | ||
| ('unittest.makeSuite(Tests, prefix="arg")',), |
There was a problem hiding this comment.
these don't have to be 1-tuples -- can just be strings
asottile
reviewed
Sep 21, 2023
Comment on lines
19
to
20
| ('unittest.makeSuite(Tests, "arg")'), | ||
| ('unittest.makeSuite(Tests, prefix="arg")'), |
asottile
reviewed
Sep 21, 2023
| ( | ||
| pytest.param( | ||
| 'class ExampleTests:\n' | ||
| ' def test_something(self):\n' | ||
| ' self.assertEqual(1, 1)\n', | ||
| id='not a deprecated alias', | ||
| ), | ||
| # https://github.com/asottile/pyupgrade/issues/749# |
There was a problem hiding this comment.
if this link is important put it in the pytest id -- if it's not remove it -- also it contains a typo
piazzesiNiccolo
force-pushed
the
unit_test_deprecated_aliases_bug
branch
from
592ad5e
to
7d86735
Compare
|
the commit message is kinda unclear here -- it probably should be something closer to "prevent rewriting unittest module functions with additional arguments" -- or something like it |
piazzesiNiccolo
force-pushed
the
unit_test_deprecated_aliases_bug
branch
from
7d86735
to
22d8c6c
Compare
|
just mistakenly copied an old git command when changing commit message, fixing this |
piazzesiNiccolo
force-pushed
the
unit_test_deprecated_aliases_bug
branch
from
22d8c6c
to
c98e8ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #749.
I saw that #759 was closed without actually fixing the issue.