Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add ability to test against tools from source #532

Merged
merged 3 commits into from
Sep 21, 2023
Merged

refactor: add ability to test against tools from source #532

merged 3 commits into from
Sep 21, 2023

Conversation

thesayyn
Copy link
Member

@thesayyn thesayyn commented Sep 20, 2023 •
edited

Type of change

  • Refactor (a code change that neither fixes a bug or adds a new feature)

Test plan

  • New test cases added

This effectively solves the two-release problem we have by consuming the tools from the source at root/main workspace, making our tests always run against the source version of tools. Additionally, it introduces the automatic generation of versions.bzl file for all tools, with tests in place to prevent wrong version information from being stamped.

@thesayyn thesayyn force-pushed the source_toolchain branch 4 times, most recently from 637fac3 to 93af528 Compare September 20, 2023 22:58
@thesayyn thesayyn marked this pull request as draft September 20, 2023 23:29
@thesayyn thesayyn marked this pull request as ready for review September 21, 2023 00:37
@thesayyn thesayyn requested review from alexeagle, gregmagolan and jbedard and removed request for alexeagle and gregmagolan September 21, 2023 00:49
alexeagle
alexeagle approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Can you roll this change to GoogleContainerTools/container-structure-test as well?

.github/workflows/release.yml Outdated Show resolved Hide resolved
tools/versions.bzl Show resolved Hide resolved
@alexeagle alexeagle mentioned this pull request Sep 21, 2023
Merged
@thesayyn thesayyn force-pushed the source_toolchain branch 2 times, most recently from 38b0ec2 to fc308ac Compare September 21, 2023 21:42
@thesayyn thesayyn mentioned this pull request Sep 21, 2023
Merged
@thesayyn thesayyn requested review from jbedard and removed request for gregmagolan September 21, 2023 21:56
@thesayyn
Copy link
Member Author

This is great! Can you roll this change to GoogleContainerTools/container-structure-test as well?

Yes, after cutting a release here.

@thesayyn thesayyn merged commit 719b8f3 into main Sep 21, 2023
50 checks passed
@thesayyn thesayyn deleted the source_toolchain branch September 21, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@jbedard jbedard Awaiting requested review from jbedard

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thesayyn @alexeagle @jbedard