[docs] - Fix admonition hyperlink colouring #9385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change colouring for admonition hyperlinks in dark theme to a more readable colour Signed-off-by: 64815328+Eutropios@users.noreply.github.com
This was referenced Jan 13, 2024
charliermarsh
pushed a commit
that referenced
this pull request
Jan 13, 2024
## Summary The admonition in dark mode are in actually same as in light mode here: https://docs.astral.sh/ruff/formatter/#ruff-format I propose to move admonition in real dark mode as shown below: - Before the PR #9385  - Current version  - Proposal  Close #9501 ## Test Plan Documentation was regenerated via mkdocs and the supplied requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the colouration of hyperlinks within admonitions on dark theme to be more readable. Closes #9046
Test Plan
Documentation was regenerated via mkdocs and the supplied requirements.