This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Integrate packager improvements from https://github.com/atom/atom/pull/15431 #19324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafeca
commented
May 13, 2019
| out: CONFIG.buildOutputPath, | ||
| overwrite: true, | ||
| platform: process.platform, | ||
| // Atom doesn't have devDependencies, but if prune is true, it will delete the non-standard packageDependencies. |
There was a problem hiding this comment.
That's actually really cool! @malept does this mean that if we enable this option we can start using devDependencies on the top-level package.json without adding them to the app package? 😍
/cc @nathansobo , @smashwilson , @jasonrudolph
There was a problem hiding this comment.
As I mentioned in the comment, packageDependencies is still problematic (i.e., gets pruned) if prune: true is set. If Packager needs to deal with this use case, we'd have to do some refactoring of how pruning works (that is, add support for custom *Dependencies in package.json to be whitelisted).
There was a problem hiding this comment.
Oh, I understood the comment incorrectly, thanks for clarifying 👍
rafeca
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #19318 to integrate the changes made by @malept on #15431