This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Integrate packager improvements from https://github.com/atom/atom/pull/15431 #19324
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
83c6688
:arrow_up: Electron Packager 9
malept 1d0b39b
Simplify icon param for Electron Packager
malept 8bcdeb1
Fix whitespace
malept 875d049
:arrow_up: Electron Packager 10
malept 1e08779
Disable pruning dependencies and add a note as to why
malept 539ba5d
Use Electron Packager's hostArch() instead of process.arch due to arm…
malept 0056743
:arrow_up: Electron Packager 11
malept 6b3e906
Merge branch 'master' into HEAD
rafeca File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's actually really cool! @malept does this mean that if we enable this option we can start using
devDependencies
on the top-levelpackage.json
without adding them to the app package? 😍/cc @nathansobo , @smashwilson , @jasonrudolph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned in the comment,
packageDependencies
is still problematic (i.e., gets pruned) ifprune: true
is set. If Packager needs to deal with this use case, we'd have to do some refactoring of how pruning works (that is, add support for custom*Dependencies
inpackage.json
to be whitelisted).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I understood the comment incorrectly, thanks for clarifying 👍