This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Upgrade to Electron 4 #19373
Merged
Merged
Upgrade to Electron 4 #19373
Changes from 3 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
5571a7c
⬆️ electron@4.2.0
rafeca eb2f091
⬆️ electron-chromedriver@4.0.0-beta.1
rafeca abaaf75
⬆️ electron-mksnapshot@4.2.0
rafeca a4c6f31
Merge branch 'master' into electron-4
50Wliu 218657f
Use new attributeStyleMap for elements
daviwil 4c47249
Use correct fontWeight value in ThemeManager spec
daviwil d988983
Forward-port chromedriver changes
50Wliu a1aa1bb
:arrow_up: apm prerelease for updated Node
50Wliu 1483f4b
:arrow_up: @atom/nsfw, git-utils to allow loading on Windows
50Wliu 906a106
:arrow_up: scandal to update nested git-utils dependency
50Wliu cfaca0a
Temporarily disable snapshotting
50Wliu 7f5e639
Try updating @atom/nsfw to 1.0.23-1
50Wliu c2f1d65
Oops, package lock it
50Wliu a186961
Don't add menu items without labels
50Wliu 10c1c97
Update Electron builtins
50Wliu 00362cc
Investigate chromedriver failures
50Wliu 1ebfcba
Merge branch 'master' into electron-4
50Wliu 3e6d7cc
Re-enable snapshotting
50Wliu 5f0aad2
Merge branch 'master' into electron-4
50Wliu 6e90fbe
Back to manual debugging it is
50Wliu 5ddb665
Merge branch 'master' into electron-4
rafeca 8ad7aa0
⬆️ electron-chromedriver@4.2.0
rafeca 60093e4
Revert "Back to manual debugging it is"
rafeca 91b53d4
Use random port to initialize ChromeDriver
rafeca 5b61fba
Merge branch 'master' into electron-4
rafeca 9663c79
⬆️ electron@4.2.5
rafeca 79a952b
⬆️ electron@4.2.6
rafeca f7f002f
Merge branch 'master' into electron-4
rafeca a8e2c83
⬆️ electron@4.2.7
rafeca File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it more practical to use 4.2.2 to also have the latest bugfixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not go straight to
v5.0.1?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just about being incremental. We tried to go to 3 first, but we're hitting #19372, so we wanted to see how we'd do in 4. Unfortunately we still don't really know if the crash is fixed on Electron 4 because we can't get it started yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yeah, we should be on the latest patch release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.2.3 has been released yesterday
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And 4.2.4 has been tagged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And 4.2.5 has been tagged now too