This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
switch to custom prebuild-install package #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daviwil feel free to merge when you have time to cut a release |
|
Will do! |
|
v4.3.2 is out 🎉 |
This was referenced Feb 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for #133 by adding behaviour to
prebuild-install. You can see the changes made on top ofv5.2.1in this diff: shiftkey/prebuild-install@1afb0a4...electron-workaroundTODO:
prebuild-install-s are skipped with a helpful messageprebuild-installis unaffectedprebuild-installis unaffectedcc @daviwil @bendemboski for input