Remove vm from simulator #796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quote> vm package is removed. Few stuff has been moved into internal package
It deletes some functions signature and unused consts
najeal
requested review from
samliok,
dboehm-avalabs and
richardpringle
as code owners
|
@najeal going to take a little bit to get to this. I might also cause some conflicts. Sorry for the delay |
|
@richardpringle don't worry 🙂 |
|
This PR has become stale because it has been open for 30 days with no activity. Adding the |
|
@richardpringle Do you think I can resolve conflicts? |
|
@najeal, I'm going to close this one since there were so many changes. I'm going to say that we shouldn't do this right away (at least for now). Thanks again for the contribution! Even if it didn't land, the PR will be here if someone wants to take a look in the future and we all really appreciate the efforts! |
|
@richardpringle Don’t hesitate to ping me when you want it, I would be glad to make it 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related and closes #756
It deletes the
vmpackage and moved the important stuff ininternal.DB cleanup previously managed by the VM is now explicitly done in
cleanupfunction of the simulator.