Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datastore): Move conflict resolution tests to their own file #12728

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

stocaaro
Copy link
Contributor

@stocaaro stocaaro commented Dec 19, 2023

Description of changes

Outcome:

  • The sequence / conflict resolution testing is separated out from other connection testing
  • There are no changes in this aside from migrating the tests and the before / after blocks needed to keep them working.

Description of how you validated changes

This change is a pure refactor of test code. It is validated as correct since all tests continue to pass.

Related changes

  1. 馃尡 refactor(datastore): Move conflict resolution tests to their own file
  2. refactor(datastore): Refactor conflict resolution tests optimize for concise/readable聽#12732
  3. refactor(datastore): Refactor test names and make subscription events more sample app like聽#12740
  4. test(datastore): Add OptimisticConcurrency tests聽#12795
  5. fix(datastore): Update outbox comparison logic to fix update versioning problems聽stocaaro/amplify-js#87

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stocaaro stocaaro requested a review from a team as a code owner December 19, 2023 19:47
Copy link
Member

@david-mcafee david-mcafee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving these! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants