-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(datastore): Refactor test names and make subscription events more sample app like #12740
refactor(datastore): Refactor test names and make subscription events more sample app like #12740
Conversation
Co-authored-by: David McAfee <mcafd@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these changes result in different test assertions, I think I'd like to see a few comments explaining exactly what's happening (and why) - specific comments requesting those changes are included inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for responding to my previous questions on this one! Left two minor (non-blocking) suggestions.
Co-authored-by: David McAfee <mcafd@amazon.com>
Description of changes
Outcome:
Description of how you validated changes
Tests updated in reference to how users receive settled updates twice in sample apps (once via mutation response and then later via subscription update).
Related changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.