Fix generated SDK errors to use pointer receivers (#3207)

Fixes the generated SDK API errors to use pointer function receivers
instead of value. This fixes potential confusion writing code and not
casting to the correct type. The SDK will always return the API error as
a pointer, not value.

Code that did type assertions from the operation's returned error to the
value type would never be satisfied. Leading to errors being missed.
Changing the function receiver to a pointer prevents this error.
Highlighting it in code bases.

CHANGELOG_PENDING.md

@@ -4,3 +4,6 @@
 * Update SDK's `go-jmespath` dependency to latest tagged version `0.3.0` ([#3205](https://github.com/aws/aws-sdk-go/pull/3205))
 
 ### SDK Bugs
+* Fix generated SDK errors to use pointer receivers
+  * Fixes the generated SDK API errors to use pointer function receivers instead of value. This fixes potential confusion writing code and not casting to the correct type. The SDK will always return the API error as a pointer, not value.
+  * Code that did type assertions from the operation's returned error to the value type would never be satisfied. Leading to errors being missed. Changing the function receiver to a pointer prevents this error. Highlighting it in code bases.

private/model/api/shape.go

@@ -814,12 +814,12 @@ func newError{{ $.ShapeName }}(v protocol.ResponseMetadata) error {
 }
 
 // Code returns the exception type name.
-func (s {{ $.ShapeName }}) Code() string {
+func (s *{{ $.ShapeName }}) Code() string {
 	return "{{ $.ErrorName }}"
 }
 
 // Message returns the exception's message.
-func (s {{ $.ShapeName }}) Message() string {
+func (s *{{ $.ShapeName }}) Message() string {
 	{{- if index $.MemberRefs "Message_" }}
 		if s.Message_ != nil {
 			return *s.Message_
@@ -829,11 +829,11 @@ func (s {{ $.ShapeName }}) Message() string {
 }
 
 // OrigErr always returns nil, satisfies awserr.Error interface.
-func (s {{ $.ShapeName }}) OrigErr() error {
+func (s *{{ $.ShapeName }}) OrigErr() error {
 	return nil
 }
 
-func (s {{ $.ShapeName }}) Error() string {
+func (s *{{ $.ShapeName }}) Error() string {
 	{{- if or (and (eq (len $.MemberRefs) 1) (not (index $.MemberRefs "Message_"))) (gt (len $.MemberRefs) 1) }}
 		return fmt.Sprintf("%s: %s\n%s", s.Code(), s.Message(), s.String())
 	{{- else }}
@@ -842,12 +842,12 @@ func (s {{ $.ShapeName }}) Error() string {
 }
 
 // Status code returns the HTTP status code for the request's response error.
-func (s {{ $.ShapeName }}) StatusCode() int {
+func (s *{{ $.ShapeName }}) StatusCode() int {
 	return s.RespMetadata.StatusCode
 }
 
 // RequestID returns the service's response RequestID for request.
-func (s {{ $.ShapeName }}) RequestID() string {
+func (s *{{ $.ShapeName }}) RequestID() string {
 	return s.RespMetadata.RequestID
 }
 `))