Update go-jmespath to a release tag #3205
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
approved these changes
Mar 16, 2020
|
@jasdel Just wanted to check in and see if you needed anything from me here |
|
Thanks for the ping, looks like Travis build was a temp failure. restarting it then we should be able to merge in this change. |
|
Great, thanks!
…On Tue, Mar 24, 2020 at 5:24 PM Jason Del Ponte ***@***.***> wrote:
Thanks for the ping, looks like Travis build was a temp failure.
restarting it then we should be able to merge in this change.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3205 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBD6FAC4YQ3Y6T7LT5DRJEQJ5ANCNFSM4LGWFOGA>
.
--
All that is necessary for evil to succeed is for good people to do nothing.
|
|
Looks like it flaked again. Is this a common occurrence? |
|
Hi @alex looks like we're having an permission issue with TravisCI. We may have to bypass the CR since this failure is transient. |
|
Thanks! Excited to see this using a tagged release now. |
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Mar 30, 2020
=== ### Service Client Updates * `service/accessanalyzer`: Updates service API and documentation ### SDK Features * SDK generated errors are fixed to use pointer receivers preventing confusion, and potential impossible type assertions. The SDK will only return API generated API error types as pointers. This fix ensures Go's type system will catch invalid error type assertions. ### SDK Enhancements * Update SDK's `go-jmespath` dependency to latest tagged version `0.3.0` ([#3205](#3205)) ### SDK Bugs * Fix generated SDK errors to use pointer receivers * Fixes the generated SDK API errors to use pointer function receivers instead of value. This fixes potential confusion writing code and not casting to the correct type. The SDK will always return the API error as a pointer, not value. * Code that did type assertions from the operation's returned error to the value type would never be satisfied. Leading to errors being missed. Changing the function receiver to a pointer prevents this error. Highlighting it in code bases.
Merged
aws-sdk-go-automation
added a commit
that referenced
this pull request
Mar 30, 2020
Release v1.30.0 (2020-03-30) === ### Service Client Updates * `service/accessanalyzer`: Updates service API and documentation ### SDK Features * SDK generated errors are fixed to use pointer receivers preventing confusion, and potential impossible type assertions. The SDK will only return API generated API error types as pointers. This fix ensures Go's type system will catch invalid error type assertions. ### SDK Enhancements * Update SDK's `go-jmespath` dependency to latest tagged version `0.3.0` ([#3205](#3205)) ### SDK Bugs * Fix generated SDK errors to use pointer receivers * Fixes the generated SDK API errors to use pointer function receivers instead of value. This fixes potential confusion writing code and not casting to the correct type. The SDK will always return the API error as a pointer, not value. * Code that did type assertions from the operation's returned error to the value type would never be satisfied. Leading to errors being missed. Changing the function receiver to a pointer prevents this error. Highlighting it in code bases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.