Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(smithy-client): skip emitting warning for Node.js 12.x #4127

Merged
merged 1 commit into from Nov 1, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 1, 2022

Issue

Internal JS-3680

Support for Node.js 12.x ended in #4123

Description

Skips emitting warning for Node.js 12.x

Testing

N/A

Additional context

Node.js 12.x doesn't parse Nullish coalescing operator, so clients will not work in Node.js 12.x

// test.js
const { DynamoDB } = require("../aws-sdk-js-v3/clients/client-dynamodb");
const { S3 } = require("../aws-sdk-js-v3/clients/client-s3");

const dynamodbClient = new DynamoDB();
const s3Client = new S3();
$ node -v
v12.22.12

$ node test.js 
/local/home/trivikr/workspace/aws-sdk-js-v3/clients/client-dynamodb/dist-cjs/protocols/Aws_json1_0.js:3547
        ClientRequestToken: input.ClientRequestToken ?? (0, uuid_1.v4)(),
                                                      ^

SyntaxError: Unexpected token '?'
    at wrapSafe (internal/modules/cjs/loader.js:915:16)
    at Module._compile (internal/modules/cjs/loader.js:963:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/local/home/trivikr/workspace/aws-sdk-js-v3/clients/client-dynamodb/dist-cjs/commands/BatchExecuteStatementCommand.js:8:23)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr merged commit 33f5ef6 into aws:main Nov 1, 2022
@trivikr trivikr deleted the update-deprecation-msg branch November 1, 2022 05:54
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants