Java: Add BZMPOP command
#1390
Merged
Java: Add BZMPOP command
#1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `BZMPOP` command. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add a test. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Reorder args. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Groom glide core. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update glide-core/src/client/value_conversion.rs Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com>
…MPOP Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…MPOP Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Yury-Fridlyand
requested review from
GumpacG,
aaron-congo,
jonathanl-bq,
barshaul,
acarbonetto,
tjzhang-BQ and
shohamazon
GumpacG
approved these changes
May 8, 2024
aaron-congo
reviewed
May 9, 2024
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Blocks the connection until it pops and returns multiple member-score pairs from the sorted | ||
| * sets stored at the specified <code>keys</code>. The sorted sets are checked in the order they | ||
| * are provided.<br> |
There was a problem hiding this comment.
Do we want to clarify the following? It was something I wasn't sure about until I saw it in the redis.io docs
Suggested change
| * are provided.<br> | |
| * are provided. The number of popped elements is the minimum | |
| from the sorted set's cardinality and `count`.<br> |
There was a problem hiding this comment.
Too obvious isn't it? What others think?
There was a problem hiding this comment.
Maybe. Either way, not a big deal, you can decide if you want to include it or not
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
|
I implemented this for Python (PR is not up yet) and the transaction tests were failing with a cross slot error. This was because BZMPOP needs to be added to cluster_routing.rs#base_routing, since it doesn't fall under the default FirstKey category. Mapping BZMPOP to ThirdArgAfterKeyCount locally solved the problem for me. Do you know why the transaction tests are passing here even though cluster_routing.rs hasn't been updated for BZMPOP yet? |
No idea. I know, few tests in #1284 fail which pass here. Looking forward to run tests with fixed routing. |
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…MPOP Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…MPOP Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
aaron-congo
approved these changes
May 10, 2024
acarbonetto
reviewed
May 10, 2024
java/client/src/main/java/glide/api/models/commands/ScoreModifier.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
acarbonetto
approved these changes
May 13, 2024
Elen-Ghulam
approved these changes
May 13, 2024
avifenesh
pushed a commit
that referenced
this pull request
May 14, 2024
* Java: Add `BZMPOP` command (#194) * Add `BZMPOP` command. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add a test. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Reorder args. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Groom glide core. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update glide-core/src/client/value_conversion.rs Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update glide-core/src/client/value_conversion.rs Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Rename Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: jonathanl-bq <72158117+jonathanl-bq@users.noreply.github.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
https://redis.io/commands/bzmpop/
Ref: #1255 and #1248
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.