Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing HTTPS proxy from env #2933

Closed
wants to merge 1 commit into from
Closed

Commits on Apr 28, 2020

  1. Fixing HTTPS proxy from env

    Inside the http adapter we use a check on `proxy.protocol` to determine
    whether to use HTTP or HTTPS transport
    This works fine when we use a `protocol` key in the `proxy`
    configuration object
    However when the proxy configuration comes from the `http_proxy` or
    `https_proxy` environment variable, we parse the URL to set the `host`
    and `port` keys in the proxy configuration **but** the protocol is never
    extracted from that URL thus causing HTTPS requests to always use HTTP
    transport.
    tonywanteeed committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    3a2818e View commit details
    Browse the repository at this point in the history