Fixing HTTPS proxy from env #2933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inside the http adapter we use a check on `proxy.protocol` to determine whether to use HTTP or HTTPS transport This works fine when we use a `protocol` key in the `proxy` configuration object However when the proxy configuration comes from the `http_proxy` or `https_proxy` environment variable, we parse the URL to set the `host` and `port` keys in the proxy configuration **but** the protocol is never extracted from that URL thus causing HTTPS requests to always use HTTP transport.
|
Same as #2562 |
|
Hi @tonywanteeed, Firstly thanks for the contribution, but this seems to be a duplicate of #2562 so I am going to close it due to it being a duplicate. Please feel free to help with other issues if you would like. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside the http adapter we use a check on
proxy.protocolto determinewhether to use HTTP or HTTPS transport
This works fine when we use a
protocolkey in theproxyconfiguration object
However when the proxy configuration comes from the
http_proxyorhttps_proxyenvironment variable, we parse the URL to set thehostand
portkeys in the proxy configuration but the protocol is neverextracted from that URL thus causing HTTPS requests to always use HTTP
transport.
I've tried to add some tests to
test/unit/adapters/http.jsto validate the fix but it requires both the server and the proxy to use HTTPS. As the other tests seems to focus on HTTP proxies and servers I don't know how to add those.I'm willing to work on them if you can point me in the right direction.