Mark class prototype as read-only (#12115)

* initial code 2 fix the issue #2025 * Mark class prototype as read-only * Update fixtures * Fix failure * Update Babel 8 fixtures * Disable in loose mode * Update fixtures Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
babel · Dec 10, 2021 · c59870c · c59870c
1 parent 3908049
commit c59870c
Show file tree

Hide file tree

Showing 221 changed files with 490 additions and 458 deletions.
diff --git a/packages/babel-cli/test/fixtures/babel-external-helpers/--whitelist/stdout.txt b/packages/babel-cli/test/fixtures/babel-external-helpers/--whitelist/stdout.txt
@@ -14,6 +14,9 @@
   function _createClass(Constructor, protoProps, staticProps) {
     if (protoProps) _defineProperties(Constructor.prototype, protoProps);
     if (staticProps) _defineProperties(Constructor, staticProps);
+    Object.defineProperty(Constructor, "prototype", {
+      writable: false
+    });
     return Constructor;
   }
 

diff --git a/packages/babel-core/test/fixtures/transformation/misc/regression-1155/output.js b/packages/babel-core/test/fixtures/transformation/misc/regression-1155/output.js
@@ -16,5 +16,5 @@ var Foo = /*#__PURE__*/function (_Bar) {
     return _super.call(this, parentOptions);
   }
 
-  return Foo;
+  return babelHelpers.createClass(Foo);
 }(Bar);
diff --git a/packages/babel-helpers/src/helpers.ts b/packages/babel-helpers/src/helpers.ts
@@ -223,6 +223,7 @@ helpers.createClass = helper("7.0.0-beta.0")`
   export default function _createClass(Constructor, protoProps, staticProps) {
     if (protoProps) _defineProperties(Constructor.prototype, protoProps);
     if (staticProps) _defineProperties(Constructor, staticProps);
+    Object.defineProperty(Constructor, "prototype", { writable: false });
     return Constructor;
   }
 `;
@@ -334,12 +335,15 @@ helpers.inherits = helper("7.0.0-beta.0")`
     if (typeof superClass !== "function" && superClass !== null) {
       throw new TypeError("Super expression must either be null or a function");
     }
-    subClass.prototype = Object.create(superClass && superClass.prototype, {
-      constructor: {
-        value: subClass,
-        writable: true,
-        configurable: true
-      }
+    Object.defineProperty(subClass, "prototype", {
+      value: Object.create(superClass && superClass.prototype, {
+        constructor: {
+          value: subClass,
+          writable: true,
+          configurable: true
+        }
+      }),
+      writable: false,
     });
     if (superClass) setPrototypeOf(subClass, superClass);
   }

diff --git a/...-proposal-class-properties/test/fixtures/assumption-setPublicClassFields/foobar/output.js b/...-proposal-class-properties/test/fixtures/assumption-setPublicClassFields/foobar/output.js
@@ -18,5 +18,5 @@ var Child = /*#__PURE__*/function (_Parent) {
     return _this;
   }
 
-  return Child;
+  return babelHelpers.createClass(Child);
 }(Parent);
diff --git a/...-class-properties/test/fixtures/decorators-legacy-interop/local-define-property/output.js b/...-class-properties/test/fixtures/decorators-legacy-interop/local-define-property/output.js
@@ -5,14 +5,14 @@ function dec() {} // Create a local function binding so babel has to change the
 
 function _defineProperty() {}
 
-let A = (_class = function A() {
+let A = (_class = /*#__PURE__*/babelHelpers.createClass(function A() {
   "use strict";
 
   babelHelpers.classCallCheck(this, A);
   babelHelpers.initializerDefineProperty(this, "a", _descriptor, this);
   babelHelpers.initializerDefineProperty(this, "b", _descriptor2, this);
   babelHelpers.defineProperty(this, "c", 456);
-}, (_descriptor = babelHelpers.applyDecoratedDescriptor(_class.prototype, "a", [dec], {
+}), (_descriptor = babelHelpers.applyDecoratedDescriptor(_class.prototype, "a", [dec], {
   configurable: true,
   enumerable: true,
   writable: true,

diff --git a/...-plugin-proposal-class-properties/test/fixtures/decorators-legacy-interop/loose/output.js b/...-plugin-proposal-class-properties/test/fixtures/decorators-legacy-interop/loose/output.js
@@ -2,14 +2,14 @@ var _class, _descriptor, _descriptor2;
 
 function dec() {}
 
-let A = (_class = function A() {
+let A = (_class = /*#__PURE__*/babelHelpers.createClass(function A() {
   "use strict";
 
   babelHelpers.classCallCheck(this, A);
   babelHelpers.initializerDefineProperty(this, "a", _descriptor, this);
   babelHelpers.initializerDefineProperty(this, "b", _descriptor2, this);
   this.c = 456;
-}, (_descriptor = babelHelpers.applyDecoratedDescriptor(_class.prototype, "a", [dec], {
+}), (_descriptor = babelHelpers.applyDecoratedDescriptor(_class.prototype, "a", [dec], {
   configurable: true,
   enumerable: true,
   writable: true,

diff --git a/...plugin-proposal-class-properties/test/fixtures/decorators-legacy-interop/strict/output.js b/...plugin-proposal-class-properties/test/fixtures/decorators-legacy-interop/strict/output.js
@@ -2,14 +2,14 @@ var _class, _descriptor, _descriptor2;
 
 function dec() {}
 
-let A = (_class = function A() {
+let A = (_class = /*#__PURE__*/babelHelpers.createClass(function A() {
   "use strict";
 
   babelHelpers.classCallCheck(this, A);
   babelHelpers.initializerDefineProperty(this, "a", _descriptor, this);
   babelHelpers.initializerDefineProperty(this, "b", _descriptor2, this);
   babelHelpers.defineProperty(this, "c", 456);
-}, (_descriptor = babelHelpers.applyDecoratedDescriptor(_class.prototype, "a", [dec], {
+}), (_descriptor = babelHelpers.applyDecoratedDescriptor(_class.prototype, "a", [dec], {
   configurable: true,
   enumerable: true,
   writable: true,

diff --git a/...l-plugin-proposal-class-properties/test/fixtures/nested-class/super-call-in-key/output.js b/...l-plugin-proposal-class-properties/test/fixtures/nested-class/super-call-in-key/output.js
@@ -1,14 +1,14 @@
 "use strict";
 
-let Hello = function Hello() {
+let Hello = /*#__PURE__*/babelHelpers.createClass(function Hello() {
   babelHelpers.classCallCheck(this, Hello);
   return {
     toString() {
       return 'hello';
     }
 
   };
-};
+});
 
 let Outer = /*#__PURE__*/function (_Hello) {
   babelHelpers.inherits(Outer, _Hello);
@@ -22,16 +22,14 @@ let Outer = /*#__PURE__*/function (_Hello) {
 
     babelHelpers.classCallCheck(this, Outer);
     _this2 = _this = _super.call(this);
-
-    let Inner = function Inner() {
+    let Inner = /*#__PURE__*/babelHelpers.createClass(function Inner() {
       babelHelpers.classCallCheck(this, Inner);
       babelHelpers.defineProperty(this, _this2, "hello");
-    };
-
+    });
     return babelHelpers.possibleConstructorReturn(_this, new Inner());
   }
 
-  return Outer;
+  return babelHelpers.createClass(Outer);
 }(Hello);
 
 expect(new Outer().hello).toBe('hello');
diff --git a/...ugin-proposal-class-properties/test/fixtures/nested-class/super-property-in-key/output.js b/...ugin-proposal-class-properties/test/fixtures/nested-class/super-property-in-key/output.js
@@ -27,16 +27,14 @@ let Outer = /*#__PURE__*/function (_Hello) {
     babelHelpers.classCallCheck(this, Outer);
     _this = _super.call(this);
     _babelHelpers$get$cal = babelHelpers.get((_thisSuper = babelHelpers.assertThisInitialized(_this), babelHelpers.getPrototypeOf(Outer.prototype)), "toString", _thisSuper).call(_thisSuper);
-
-    let Inner = function Inner() {
+    let Inner = /*#__PURE__*/babelHelpers.createClass(function Inner() {
       babelHelpers.classCallCheck(this, Inner);
       babelHelpers.defineProperty(this, _babelHelpers$get$cal, 'hello');
-    };
-
+    });
     return babelHelpers.possibleConstructorReturn(_this, new Inner());
   }
 
-  return Outer;
+  return babelHelpers.createClass(Outer);
 }(Hello);
 
 expect(new Outer().hello).toBe('hello');
diff --git a/...gin-proposal-class-properties/test/fixtures/private-loose/constructor-collision/output.js b/...gin-proposal-class-properties/test/fixtures/private-loose/constructor-collision/output.js
@@ -2,7 +2,7 @@ var foo = "bar";
 
 var _bar = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("bar");
 
-var Foo = function Foo() {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo() {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
@@ -11,4 +11,4 @@ var Foo = function Foo() {
     value: foo
   });
   var _foo = "foo";
-};
+});
diff --git a/...-plugin-proposal-class-properties/test/fixtures/private-loose/declaration-order/output.js b/...-plugin-proposal-class-properties/test/fixtures/private-loose/declaration-order/output.js
@@ -1,6 +1,6 @@
 var _x = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("x");
 
-var C = function C() {
+var C = /*#__PURE__*/babelHelpers.createClass(function C() {
   "use strict";
 
   babelHelpers.classCallCheck(this, C);
@@ -9,8 +9,7 @@ var C = function C() {
     writable: true,
     value: void 0
   });
-};
-
+});
 expect(() => {
   new C();
 }).toThrow();
diff --git a/...n-proposal-class-properties/test/fixtures/private-loose/derived-multiple-supers/output.js b/...n-proposal-class-properties/test/fixtures/private-loose/derived-multiple-supers/output.js
@@ -29,5 +29,5 @@ var Foo = /*#__PURE__*/function (_Bar) {
     return babelHelpers.possibleConstructorReturn(_this);
   }
 
-  return Foo;
+  return babelHelpers.createClass(Foo);
 }(Bar);
diff --git a/...ages/babel-plugin-proposal-class-properties/test/fixtures/private-loose/derived/output.js b/...ages/babel-plugin-proposal-class-properties/test/fixtures/private-loose/derived/output.js
@@ -1,14 +1,14 @@
 var _prop = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("prop");
 
-var Foo = function Foo() {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo() {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
   Object.defineProperty(this, _prop, {
     writable: true,
     value: "foo"
   });
-};
+});
 
 var _prop2 = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("prop");
 
@@ -31,5 +31,5 @@ var Bar = /*#__PURE__*/function (_Foo) {
     return _this;
   }
 
-  return Bar;
+  return babelHelpers.createClass(Bar);
 }(Foo);
diff --git a/...osal-class-properties/test/fixtures/private-loose/destructuring-array-pattern-1/output.js b/...osal-class-properties/test/fixtures/private-loose/destructuring-array-pattern-1/output.js
@@ -1,6 +1,6 @@
 var _client = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("client");
 
-var Foo = function Foo(props) {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo(props) {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
@@ -10,4 +10,4 @@ var Foo = function Foo(props) {
   });
   babelHelpers.classPrivateFieldLooseBase(this, _client)[_client] = 1;
   [this.x = babelHelpers.classPrivateFieldLooseBase(this, _client)[_client], babelHelpers.classPrivateFieldLooseBase(this, _client)[_client], this.y = babelHelpers.classPrivateFieldLooseBase(this, _client)[_client]] = props;
-};
+});
diff --git a/...osal-class-properties/test/fixtures/private-loose/destructuring-array-pattern-2/output.js b/...osal-class-properties/test/fixtures/private-loose/destructuring-array-pattern-2/output.js
@@ -1,6 +1,6 @@
 var _client = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("client");
 
-var Foo = function Foo(props) {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo(props) {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
@@ -9,4 +9,4 @@ var Foo = function Foo(props) {
     value: void 0
   });
   [x, ...babelHelpers.classPrivateFieldLooseBase(this, _client)[_client]] = props;
-};
+});
diff --git a/...osal-class-properties/test/fixtures/private-loose/destructuring-array-pattern-3/output.js b/...osal-class-properties/test/fixtures/private-loose/destructuring-array-pattern-3/output.js
@@ -1,6 +1,6 @@
 var _client = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("client");
 
-var Foo = function Foo(props) {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo(props) {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
@@ -9,4 +9,4 @@ var Foo = function Foo(props) {
     value: void 0
   });
   [babelHelpers.classPrivateFieldLooseBase(this, _client)[_client] = 5] = props;
-};
+});
diff --git a/...class-properties/test/fixtures/private-loose/destructuring-array-pattern-static/output.js b/...class-properties/test/fixtures/private-loose/destructuring-array-pattern-static/output.js
@@ -1,12 +1,11 @@
 var _client = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("client");
 
-var Foo = function Foo(props) {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo(props) {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
   [babelHelpers.classPrivateFieldLooseBase(Foo, _client)[_client]] = props;
-};
-
+});
 Object.defineProperty(Foo, _client, {
   writable: true,
   value: void 0

diff --git a/...oposal-class-properties/test/fixtures/private-loose/destructuring-array-pattern/output.js b/...oposal-class-properties/test/fixtures/private-loose/destructuring-array-pattern/output.js
@@ -1,6 +1,6 @@
 var _client = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("client");
 
-var Foo = function Foo(props) {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo(props) {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
@@ -9,4 +9,4 @@ var Foo = function Foo(props) {
     value: void 0
   });
   [babelHelpers.classPrivateFieldLooseBase(this, _client)[_client]] = props;
-};
+});
diff --git a/...sal-class-properties/test/fixtures/private-loose/destructuring-object-pattern-1/output.js b/...sal-class-properties/test/fixtures/private-loose/destructuring-object-pattern-1/output.js
@@ -1,6 +1,6 @@
 var _client = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("client");
 
-var Foo = function Foo(props) {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo(props) {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
@@ -14,4 +14,4 @@ var Foo = function Foo(props) {
     y: babelHelpers.classPrivateFieldLooseBase(this, _client)[_client],
     z: this.z = babelHelpers.classPrivateFieldLooseBase(this, _client)[_client]
   } = props);
-};
+});
diff --git a/...sal-class-properties/test/fixtures/private-loose/destructuring-object-pattern-2/output.js b/...sal-class-properties/test/fixtures/private-loose/destructuring-object-pattern-2/output.js
@@ -1,6 +1,6 @@
 var _client = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("client");
 
-var Foo = function Foo(props) {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo(props) {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
@@ -12,4 +12,4 @@ var Foo = function Foo(props) {
     x,
     ...babelHelpers.classPrivateFieldLooseBase(this, _client)[_client]
   } = props);
-};
+});
diff --git a/...sal-class-properties/test/fixtures/private-loose/destructuring-object-pattern-3/output.js b/...sal-class-properties/test/fixtures/private-loose/destructuring-object-pattern-3/output.js
@@ -1,6 +1,6 @@
 var _client = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("client");
 
-var Foo = function Foo(props) {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo(props) {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
@@ -11,4 +11,4 @@ var Foo = function Foo(props) {
   ({
     client: babelHelpers.classPrivateFieldLooseBase(this, _client)[_client] = 5
   } = props);
-};
+});
diff --git a/...lass-properties/test/fixtures/private-loose/destructuring-object-pattern-static/output.js b/...lass-properties/test/fixtures/private-loose/destructuring-object-pattern-static/output.js
@@ -1,14 +1,13 @@
 var _client = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("client");
 
-var Foo = function Foo(props) {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo(props) {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
   ({
     client: babelHelpers.classPrivateFieldLooseBase(Foo, _client)[_client]
   } = props);
-};
-
+});
 Object.defineProperty(Foo, _client, {
   writable: true,
   value: void 0

diff --git a/...posal-class-properties/test/fixtures/private-loose/destructuring-object-pattern/output.js b/...posal-class-properties/test/fixtures/private-loose/destructuring-object-pattern/output.js
@@ -1,6 +1,6 @@
 var _client = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("client");
 
-var Foo = function Foo(props) {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo(props) {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
@@ -11,4 +11,4 @@ var Foo = function Foo(props) {
   ({
     client: babelHelpers.classPrivateFieldLooseBase(this, _client)[_client]
   } = props);
-};
+});
diff --git a/...bel-plugin-proposal-class-properties/test/fixtures/private-loose/extracted-this/output.js b/...bel-plugin-proposal-class-properties/test/fixtures/private-loose/extracted-this/output.js
@@ -4,7 +4,7 @@ var _bar = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("bar");
 
 var _baz = /*#__PURE__*/babelHelpers.classPrivateFieldLooseKey("baz");
 
-var Foo = function Foo(_foo) {
+var Foo = /*#__PURE__*/babelHelpers.createClass(function Foo(_foo) {
   "use strict";
 
   babelHelpers.classCallCheck(this, Foo);
@@ -16,4 +16,4 @@ var Foo = function Foo(_foo) {
     writable: true,
     value: foo
   });
-};
+});
diff --git a/packages/babel-plugin-proposal-class-properties/test/fixtures/private-loose/foobar/output.js b/packages/babel-plugin-proposal-class-properties/test/fixtures/private-loose/foobar/output.js
@@ -21,5 +21,5 @@ let Child = /*#__PURE__*/function (_Parent) {
     return _this;
   }
 
-  return Child;
+  return babelHelpers.createClass(Child);
 }(Parent);