Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel stand alone version 7.10.0 doesnt work #11628

Closed
yigalirani opened this issue May 27, 2020 · 7 comments · Fixed by #11624 or #11631
Closed

babel stand alone version 7.10.0 doesnt work #11628

yigalirani opened this issue May 27, 2020 · 7 comments · Fixed by #11624 or #11631
Labels
i: bug i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Comments

@yigalirani
Copy link

7.10 doent seems do do anything at all. null behavoir. I had to revert to 7.9

@babel-bot
Copy link
Collaborator

Hey @yigalirani! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@hamlim
Copy link
Contributor

hamlim commented May 27, 2020

We're also running into an error when using 7.10.0 with @babel/standalone while using the stage-0 preset:

Error: [BABEL] unknown: The 'moduleAttributes' plugin requires a 'version' option, representing the last proposal update. Currently, the only supported value is 'apr-2020'. (While processing: "base$1$0$0")
    at babel.min.js:1
    at babel.min.js:1
    at babel.min.js:1
    at l (babel.min.js:1)
    at Generator._invoke (babel.min.js:1)
    at Generator.forEach.e.<computed> [as next] (babel.min.js:1)
    at l (babel.min.js:1)
    at b (babel.min.js:1)
    at Generator._invoke (babel.min.js:1)
    at Generator.forEach.e.<computed> [as next] (babel.min.js:1)

It seems like the stage-1 preset defaults the version to may-2020 and that option doesn't seem to be overridable from the stage-0 preset: https://github.com/babel/babel/blob/master/packages/babel-standalone/src/preset-stage-1.js#L13

Should all options for stage-0 be spread down so users can also configure stage-1, stage-2, etc?

@hamlim
Copy link
Contributor

hamlim commented May 27, 2020

I just noticed the linked pull request won't resolve the error we're running into above, would it be better to open up a new issue to track this?

@nicolo-ribaudo
Copy link
Member

@hamlim Could you open a PR adding that option to the stage 0 preset? We can merge it for the next patch.

@hamlim
Copy link
Contributor

hamlim commented May 27, 2020

Sure!

@hamlim
Copy link
Contributor

hamlim commented May 27, 2020

@nicolo-ribaudo I tried using make build-dist to build locally and test but it doesn't seem to create the single file entry for the standalone package, do you know how I can test this locally?

Edit: Found a way to test locally, and opened the following PR: #11631

@hamlim
Copy link
Contributor

hamlim commented May 27, 2020

I think this issue should still be open as there is another issue with the 7.10 release of babel-standalone unrelated to the PR that was merged above cc @existentialism

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: bug i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
6 participants