Fix moduleAttributesVersion errors with stage-0 preset in babel standalone #11631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a6336c8:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23060/ |
| @@ -3,11 +3,11 @@ import { declare } from "@babel/helper-plugin-utils"; | |||
| export default declare((api, { version }) => { | |||
| api.assertVersion(7); | |||
|
|
|||
| if (typeof version !== "string" || version !== "apr-2020") { | |||
| if (typeof version !== "string" || version !== "may-2020") { | |||
existentialism
added
the
PR: Bug Fix 🐛
|
I now we don't have many tests for |
Sure! Would something like asserting that stage-0 doesn't throw when passing |
|
Added a small regression test 👍 |
JLHwung
reviewed
May 27, 2020
JLHwung
approved these changes
May 27, 2020
existentialism
approved these changes
May 28, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
moduleAttributesVersionconfig option on thestage-0preset for babel standalonemoduleAttributesVersiononto the config forstage-1presetmodule-attributesplugin andplugin-utilsfile (one was expectingversion: 'apr-2020'and the other was expectingversion: 'may-2020', I assumed that may is the correct version here) See: https://github.com/babel/babel/blob/master/packages/babel-parser/src/plugin-utils.js#L95-L101example.htmfile for testing the changes locallyTesting steps:
make prepublish-build-standalonenpx serve ./packages/babel-standaloneexamples/example.htm