Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only change browserslist defaults if no config file exists #9962

Closed
danez opened this issue May 9, 2019 · 2 comments
Closed

Only change browserslist defaults if no config file exists #9962

danez opened this issue May 9, 2019 · 2 comments
Labels
Has PR i: enhancement outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env
Milestone
v8.0.0

Comments

@danez
Copy link
Member

danez commented May 9, 2019 •
edited by nicolo-ribaudo

#8897 (comment)

I guess the best solution would be to check ourself if there is a browserlist config in the fs if there are not targets specified. We could do this with browserlist.findConfig(from). If we find one we do not change defaults. But that would also be a breaking change so I guess we would need to wait for v8. https://github.com/browserslist/browserslist/blob/master/node.js#L238
@danez danez added this to the Babel 8.x milestone May 9, 2019
@JLHwung JLHwung mentioned this issue Dec 16, 2019
Closed
@nicolo-ribaudo nicolo-ribaudo mentioned this issue Dec 16, 2019
Closed
14 tasks
@taralx
Copy link

taralx commented Dec 16, 2019

FYI it's "browserslist" and not "browserlist", which is why I did not originally find this one. :)

@nicolo-ribaudo nicolo-ribaudo changed the title Only change browserlist defaults if no config file exists Only change browserslist defaults if no config file exists Dec 16, 2019
@nicolo-ribaudo nicolo-ribaudo mentioned this issue Dec 18, 2019
Open
34 tasks
@JLHwung JLHwung mentioned this issue Dec 19, 2019
Closed
@JLHwung JLHwung mentioned this issue Jan 7, 2020
Closed
1 task
@JLHwung JLHwung added the Has PR label Jan 7, 2020
This was referenced Nov 17, 2020
Open
Open
Open
This was referenced Dec 16, 2020
Open
Open
Open
@JLHwung JLHwung mentioned this issue Jan 12, 2021
Closed
@nicolo-ribaudo nicolo-ribaudo mentioned this issue Jan 30, 2021
Closed
@JLHwung
Copy link
Contributor

JLHwung commented Mar 23, 2021

In Babel 8, preset-env (and other targets awared plugins) will defaults to defaults, no ie 11.

Closing this issue as it has been fixed in #12989.

@JLHwung JLHwung closed this as completed Mar 23, 2021
@JulianKniephoff JulianKniephoff mentioned this issue Mar 24, 2021
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Has PR i: enhancement outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env
Projects
None yet
Milestone
v8.0.0
3 participants
@danez @taralx @JLHwung