Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use browserlists default as the default target of preset-env #12616

Closed
wants to merge 2 commits into from

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jan 12, 2021

Q                       A
Fixed Issues? Closes #10897, fixes #9962
Patch: Bug Fix?
Major: Breaking Change? Yes, but behind the BABEL_8_BREAKING flag
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR includes commits from #12615. When the targets of preset-env is not specified, Babel 8 will use browserlists defaults query as targets. Note that although the defaults query will change between browserlists versions, it is still essentially static as ie 11 until browserlists remove ie 11 from defaults query.

As we have added targets: { "browsers": "ie 6" } to many test fixtures in #12615, the impacted test fixtures changes are limited and should be good for review.

@babel-bot
Copy link
Collaborator

babel-bot commented Jan 12, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/37407/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 12, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 990f943:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung mentioned this pull request Jan 14, 2021
34 tasks
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2021
@nicolo-ribaudo nicolo-ribaudo added this to the v8.0.0 milestone Aug 8, 2023
@JLHwung JLHwung removed this from the v8.0.0 milestone Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
babel 8 outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env
Development

Successfully merging this pull request may close these issues.

Only change browserslist defaults if no config file exists
3 participants