Try to resolve browserslist config when targets are not specified #10897
Conversation
JLHwung
added
PR: Breaking Change 💥
| // Note, if browserslist resolves the config (ex. package.json), then usage | ||
| // of `defaults` in queries will be different since we don't want to break | ||
| // the behavior of "no targets is the same as preset-latest". | ||
| if (!hasTargets) { |
There was a problem hiding this comment.
When hasTargets is false, objectToBrowserslist(targets) always return [].
| const browsers = browserslist(browsersquery, { | ||
| path: options.configPath, |
There was a problem hiding this comment.
Because browsersquery is never undefined here, browserslists will never loadConfig and therefore we don't need to pass path option here.
|
|
||
| if (shouldParseBrowsers || shouldSearchForConfig) { | ||
| const browsers = browserslist(browsersquery, { |
There was a problem hiding this comment.
When browsersquery is [], it will precede browserslists.default, therefore we don't need to overwrite browserslists.default.
JLHwung
force-pushed
the
impl-9962
branch
2 times, most recently
from
fb3666c
to
57b15e5
Compare
|
@nicolo-ribaudo Note that although technically |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/25186/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8a77cda:
|
JLHwung
force-pushed
the
impl-9962
branch
3 times, most recently
from
eda2c4d
to
cf552f2
Compare
|
Superseded by #12989 |
github-actions
bot
added
the
outdated
This PR changes the targets parsing logic when targets are empty. It will now try to resolve any
browserslistsexternal configuration and fallback toforceAllTransforms: truewhen neithertargetsis specified norbrowserslistsconfiguration is resolved.This PR also generally improves integrations with
browserslists: thebrowserslists.defaultis never changed during targets parsing. Surprisingly, by doing so we can remove a bunch of dead code.