New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flow - allow type parameter defaults in function declarations #10084
Merged
nicolo-ribaudo
merged 6 commits into
babel:master
from
tanhauhau:tanlh/feat/allow-type-parameter-default-for-function-declaration
Jun 15, 2019
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
950593d
flow - allow type parameter defaults in function declarations
tanhauhau ba1b9f7
fix flow test
tanhauhau 5a4bc72
add intern_comments option
tanhauhau 445cd2a
fix flow parser test
tanhauhau cdbed6d
remove allowdefault from flowParseTypeParameterDeclaration
tanhauhau 4141c48
rename test cases
tanhauhau File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
...ges/babel-parser/test/fixtures/flow/type-parameter-declaration/default-invalid-1/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1 @@ | ||
(class A { | ||
foo<T = string>() {} | ||
}); | ||
declare function foo<T = string>() {} | ||
4 changes: 2 additions & 2 deletions
4
...babel-parser/test/fixtures/flow/type-parameter-declaration/default-invalid-1/options.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"throws": "Unexpected token (2:8)" | ||
} | ||
"throws": "Unexpected token, expected \":\" (1:35)" | ||
} |
2 changes: 1 addition & 1 deletion
2
...ges/babel-parser/test/fixtures/flow/type-parameter-declaration/default-invalid-2/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
({ foo<T = string>() {} }); | ||
var x: Array<T = number> |
4 changes: 2 additions & 2 deletions
4
...babel-parser/test/fixtures/flow/type-parameter-declaration/default-invalid-2/options.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"throws": "Unexpected token (1:9)" | ||
} | ||
"throws": "Unexpected token, expected \",\" (1:15)" | ||
} |
2 changes: 1 addition & 1 deletion
2
...ges/babel-parser/test/fixtures/flow/type-parameter-declaration/default-invalid-3/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
declare class A { foo<T = string>(): void } | ||
class A extends B<T = number> {} |
4 changes: 2 additions & 2 deletions
4
...babel-parser/test/fixtures/flow/type-parameter-declaration/default-invalid-3/options.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"throws": "Unexpected token (1:24)" | ||
} | ||
"throws": "Unexpected token, expected \",\" (1:20)" | ||
} |
3 changes: 0 additions & 3 deletions
3
...ges/babel-parser/test/fixtures/flow/type-parameter-declaration/default-invalid-4/input.js
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
...babel-parser/test/fixtures/flow/type-parameter-declaration/default-invalid-4/options.json
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
...ges/babel-parser/test/fixtures/flow/type-parameter-declaration/default-invalid-5/input.js
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
...babel-parser/test/fixtures/flow/type-parameter-declaration/default-invalid-5/options.json
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're in here shuffling things, can we give these tests better names so we don't have to go through this renumbering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder how i should name it, i copied the test case from flow fixtures, should i renamed it based on their test id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe:
default-invalid-declare-func
default-invalid-var-type
default-invalid-class-extends
🤷♂