chore: refine e2e test scripts #10918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
JLHwung
commented
Dec 24, 2019
| @@ -5,7 +5,7 @@ | |||
| #==============================================================================# | |||
|
|
|||
| # Start in scripts/integration-tests/ even if run from root directory | |||
| cd "$(dirname "$0")" | |||
| cd "$(dirname "$0")" || exit | |||
There was a problem hiding this comment.
JLHwung
commented
Dec 24, 2019
| @@ -25,7 +25,7 @@ startLocalRegistry "$PWD"/../../verdaccio-config.yml | |||
| yarn install | |||
| # "yarn upgrade --scope @babel --latest" doesn't seem to work. | |||
| # a means "all", while \n is the enter needed to confirm the selection. | |||
| echo "a\n" | yarn upgrade-interactive --scope @babel --latest | |||
| printf "a\n" | yarn upgrade-interactive --scope @babel --latest | |||
There was a problem hiding this comment.
|
Can we run shellcheck while linting? |
|
@nicolo-ribaudo Sure. But I can add an optional |
|
Yeah making it optional sounds good. But if this PR is blocking the other one, let's do it in a separate PR. |
nicolo-ribaudo
approved these changes
Dec 24, 2019
kaicataldo
approved these changes
Dec 24, 2019
existentialism
approved these changes
Dec 24, 2019
This was referenced Feb 22, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-jto make commands.--depth=1to git clone.