Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refine e2e test scripts #10918

Merged
merged 1 commit into from Dec 24, 2019
Merged

chore: refine e2e test scripts #10918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/integration-tests/e2e-babel.sh
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
#==============================================================================#

# Start in scripts/integration-tests/ even if run from root directory
cd "$(dirname "$0")"
cd "$(dirname "$0")" || exit
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/koalaman/shellcheck/wiki/SC2164


source utils/local-registry.sh
source utils/cleanup.sh
Expand Down
8 changes: 4 additions & 4 deletions scripts/integration-tests/e2e-create-react-app.sh
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
#==============================================================================#

# Start in scripts/integration-tests/ even if run from root directory
cd "$(dirname "$0")"
cd "$(dirname "$0")" || exit

source utils/local-registry.sh
source utils/cleanup.sh
Expand All @@ -14,8 +14,8 @@ source utils/cleanup.sh
set -x

# Clone create-react-app
git clone https://github.com/facebook/create-react-app.git tmp/create-react-app
cd tmp/create-react-app
git clone --depth=1 https://github.com/facebook/create-react-app.git tmp/create-react-app
cd tmp/create-react-app || exit

#==============================================================================#
# TEST #
Expand All @@ -25,7 +25,7 @@ startLocalRegistry "$PWD"/../../verdaccio-config.yml
yarn install
# "yarn upgrade --scope @babel --latest" doesn't seem to work.
# a means "all", while \n is the enter needed to confirm the selection.
echo "a\n" | yarn upgrade-interactive --scope @babel --latest
printf "a\n" | yarn upgrade-interactive --scope @babel --latest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/koalaman/shellcheck/wiki/SC2028


# Test
CI=true yarn test
Expand Down
4 changes: 2 additions & 2 deletions scripts/integration-tests/publish-local.sh
View file
Open in desktop
Expand Up @@ -15,7 +15,7 @@ function publishESLintPkg {
cd eslint/$1
yarn version --patch --no-git-tag-version
cd ../..
make publish-eslint PKG=$1
make -j publish-eslint PKG=$1
}

# Echo every command being executed
Expand All @@ -30,7 +30,7 @@ initializeE2Egit
# PUBLISH #
#==============================================================================#

make bootstrap-only
make -j bootstrap-only

startLocalRegistry "$PWD"/scripts/integration-tests/verdaccio-config.yml
loginLocalRegistry
Expand Down