Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import type and export type support to TypeScript #11171

Merged
merged 5 commits into from Mar 16, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Feb 26, 2020

Q                       A
Fixed Issues? Fixes #10981, closes #10618, closes #8361, closes #10337
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

#11053, #11122, #11157, #11173, #11179

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories area: typescript umbrella ☂️ labels Feb 26, 2020
@nicolo-ribaudo nicolo-ribaudo added this to the v7.9.0 milestone Feb 26, 2020
@nicolo-ribaudo nicolo-ribaudo added PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release and removed PR: WIP labels Feb 26, 2020
@nicolo-ribaudo
Copy link
Member Author

The various parts of this PR have already been approved.

@nicolo-ribaudo
Copy link
Member Author

I'm removing the "ready to be merged" label per #11173 (comment)

@nicolo-ribaudo nicolo-ribaudo removed the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Feb 27, 2020
@AlCalzone
Copy link

Just out of interest: When can we expect a version (7.9.0?) containing this change to be shipped?

@nicolo-ribaudo
Copy link
Member Author

I hope to release it at the end of the next week.
I suggest checking https://github.com/babel/babel/milestone/33: we'll release when all those PRs have the "Ready to be Merged" label (i.e. 2 ✔️ )

@Bogidon
Copy link

Bogidon commented Feb 29, 2020

I compiled a babel from this PR that I'm using because I really needed the feature: 🙈
"@babel/core": "git+https://github.com/spatialsys/spatialwebapp-gitpkg-registry.git#babel-core-v7.8.4-gitpkg"

Working well!

@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Mar 1, 2020
@khanh-bes
Copy link

khanh-bes commented Mar 2, 2020

I compiled a babel from this PR that I'm using because I really needed the feature: 🙈
"@babel/core": "git+https://github.com/spatialsys/spatialwebapp-gitpkg-registry.git#babel-core-v7.8.4-gitpkg"

Working well!

This is ready to be merged already 🎆🎆

hzoo and others added 5 commits March 2, 2020 12:30
* Add parser support for type only imports in TS

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>

* Add transform and printer test for type only imports in TS

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekarm.dev@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>

* Update packages/babel-parser/src/plugins/typescript/index.js

* Fix flow

Co-authored-by: Brian Ng <bng412@gmail.com>
Co-authored-by: Raja Sekar <rajasekar.murugan@omio.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Kai Cataldo <kai@kaicataldo.com>
* [typescript] Implement "export type {}"

* test: add test on default-type-with-typescript

Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
* Add "exportKind: type" to TS type export declratation

Co-authored-by: Henry Zhu <smiley.we@gmail.com>
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Co-authored-by: Siddhant N Trivedi <sidntrivedi012@gmail.com>

* Add test to @babel/generator

Co-authored-by: Henry Zhu <hi@henryzoo.com>
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
Co-authored-by: Siddhant N Trivedi <sidntrivedi012@gmail.com>
* [plugin-transform-typescript]: onlyExplicitTypeImports

* onlyExplicitTypeImports -> onlyRemoveTypeImports

* Add test for exceptions
@tiagovtristao
Copy link

Hey @nicolo-ribaudo, good work on getting this PR up! I'm also wondering when v7.9.0 will be out?

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release umbrella ☂️
Projects
None yet
9 participants