Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace gulp-watch by gulp.watch #11175

Merged
merged 2 commits into from Feb 26, 2020
Merged

replace gulp-watch by gulp.watch #11175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d712696
chore: remove gulp-watch
JLHwung Feb 26, 2020
4949626
chore: update lock file
JLHwung Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 1 addition & 6 deletions Gulpfile.js
View file
Open in desktop
Expand Up @@ -5,7 +5,6 @@ const through = require("through2");
const chalk = require("chalk");
const newer = require("gulp-newer");
const babel = require("gulp-babel");
const gulpWatch = require("gulp-watch");
const fancyLog = require("fancy-log");
const filter = require("gulp-filter");
const gulp = require("gulp");
Expand Down Expand Up @@ -239,10 +238,6 @@ gulp.task("build-no-bundle", () => buildBabel());
gulp.task(
"watch",
gulp.series("build-no-bundle", function watch() {
gulpWatch(
defaultSourcesGlob,
{ debounceDelay: 200 },
gulp.task("build-no-bundle")
);
gulp.watch(defaultSourcesGlob, gulp.task("build-no-bundle"));
Copy link
Contributor Author

@JLHwung JLHwung Feb 26, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gulp.watch equivalent of { debouceDelay: 200 } is { delay: 200 }. According to https://gulpjs.com/docs/en/api/watch#options 200 is the default delay value, so we remove option argument here.

})
);
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -53,7 +53,6 @@
"gulp-newer": "^1.0.0",
"gulp-plumber": "^1.2.1",
"gulp-rename": "^1.4.0",
"gulp-watch": "^5.0.1",
"husky": "^3.0.0",
"jest": "^24.9.0",
"lerna": "^3.19.0",
Expand Down