New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix printing parentheses around optional chains #11190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
added
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Spec: Optional Chaining
labels
Feb 28, 2020
jridgewell
changed the title
resolve 11187
Fix printing parentheses around optional chains
Feb 28, 2020
jridgewell
approved these changes
Feb 28, 2020
existentialism
approved these changes
Feb 28, 2020
@sag1v nice work! |
JLHwung
approved these changes
Feb 28, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
This was referenced Mar 22, 2020
This was referenced Apr 11, 2020
This was referenced Apr 20, 2020
This was referenced Apr 27, 2020
This was referenced May 5, 2020
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
May 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
pkg: generator
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Spec: Optional Chaining
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
OptionalMemberExpression
to compare thecallee
forcallExpression
orobject
formemberExpression
against thenode
.This should fix a case such as:
That transforms to:
Added a
OptionalCallExpression
as well with the same checks asOptionalMemberExpression
.Should solve cases of: