Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass URLs to import() rather than paths #11193

Merged
merged 4 commits into from Mar 3, 2020
Merged

Pass URLs to import() rather than paths #11193

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4074818
Pass URLs to import() rather than paths
nicolo-ribaudo Mar 1, 2020
2204c30
Make tests pass
nicolo-ribaudo Mar 1, 2020
6238e5b
(╯°□°）╯︵ ┻━┻
nicolo-ribaudo Mar 2, 2020
21a41a8
(╯°□°）╯︵ ┻━┻ (╯°□°）╯︵ ┻━┻ (╯°□°）╯︵ ┻━┻
nicolo-ribaudo Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/babel-core/src/config/files/module-types.js
View file
Open in desktop
@@ -1,6 +1,7 @@
import { isAsync, waitFor } from "../../gensync-utils/async";
import type { Handler } from "gensync";
import path from "path";
import { pathToFileURL } from "url";

let import_;
try {
Expand Down Expand Up @@ -55,6 +56,8 @@ async function loadMjsDefault(filepath: string) {
);
}

const module = await import_(filepath);
// import() expects URLs, not file paths.
// https://github.com/nodejs/node/issues/31710
const module = await import_(pathToFileURL(filepath));
return module.default;
}