Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using preset-env with newer versions of compat-data #11201

Merged
merged 3 commits into from Mar 5, 2020
Merged

Allow using preset-env with newer versions of compat-data #11201

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7d57c7
Use ~ for preset-env's @babel/compat-data dependency
nicolo-ribaudo Mar 3, 2020
da41363
Revert "Use ~ for preset-env's @babel/compat-data dependency"
nicolo-ribaudo Mar 3, 2020
a88a007
Fix in the code
nicolo-ribaudo Mar 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Expand Up @@ -243,7 +243,7 @@ ifneq ("$(I_AM_USING_VERDACCIO)", "I_AM_SURE")
exit 1
endif
$(MAKE) prepublish-build
$(YARN) lerna version patch --force-publish=$(FORCE_PUBLISH) --no-push --yes --tag-version-prefix="version-e2e-test-"
$(YARN) lerna version minor --force-publish=$(FORCE_PUBLISH) --no-push --yes --tag-version-prefix="version-e2e-test-"
$(YARN) lerna publish from-git --registry http://localhost:4873 --yes --tag-version-prefix="version-e2e-test-"
$(MAKE) clean

Expand Down
2 changes: 1 addition & 1 deletion packages/babel-preset-env/package.json
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@
"repository": "https://github.com/babel/babel/tree/master/packages/babel-preset-env",
"main": "lib/index.js",
"dependencies": {
"@babel/compat-data": "^7.8.6",
"@babel/compat-data": "~7.8.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babel/compat-data is also depended by @babel/helper-compilation-targets. By doing so we risk having two versions of @babel/compat-data if one installs preset-env + helper-compilation-targets 7.8.0 while compat-data 7.9.0 has been published.

Can we fix this on the preset-env side? So it can work with higher compat-data as long as we would not drop entries in minor releases. We can introduce an extra unit test as a sync reminder.

"@babel/helper-compilation-targets": "^7.8.6",
"@babel/helper-module-imports": "^7.8.3",
"@babel/helper-plugin-utils": "^7.8.3",
Expand Down
2 changes: 1 addition & 1 deletion scripts/integration-tests/publish-local.sh
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ source utils/cleanup.sh

function publishESLintPkg {
cd eslint/$1
yarn version --patch --no-git-tag-version
yarn version --minor --no-git-tag-version
cd ../..
make -j publish-eslint PKG=$1
}
Expand Down