Correctly transpile when default parameter initializer references binding in rest pattern #11317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
convertParam is extracted for use in babel-plugin-proposal-object-rest-spread
The Function visitor now checks if a parameter with an initializer references a id declared in a rest pattern in a different parameter. It transforms this special case.
The original Function visitor looped over function parameters from right to left. This visitor loops from left to right, which changes the output code, without breaking it.
Add parameters without initializers to the parameters-extra test to make more thorough.
The second parameter in f({...S}, {a} = S) is now
transformed.
The previous code fails on default param intializers, like
f({...R}, a = {R}) because getBindingIdentifiers does not retrieve
"R" in the 2nd parameter. Using visitors fixes this edge case.
|
@vedantroy Can you rebase on the upstream master? |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug where
({ a, ...R }, b = R, c = a) => {}was not transpiled correctly iftransform-function-parameterswas not enabled.I used solution 2 as described by @JLHwung in the issue post. This solution loops over each param with a default initializer
a = b/nested default initializer (like{a = b}and roughly only transforms it if it is referencing a id created in an object rest pattern or if the previous parameter has been processed.For example, only the last 2 parameters in this function will be transformed.
({...b}, e, c = 2, a = b, f) => {}Looking at the "parameters-extra" tests will clarify. There are some edge cases.
Problem: Because I extracted
convertParamfromextractFunctionParamsin thebabel-plugin-transform-parameterspackage, I had to import that package into this plugin, and update thepackage.jsonfor this plugin. However, I couldn't do that because that would break thepackage-lock.json. This is causing the CI to fail, even though the tests pass locally on my computer.