Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly transpile when default parameter initializer references binding in rest pattern #11326

Merged
merged 7 commits into from Apr 7, 2020
Merged

Commits on Mar 24, 2020

  1. Transform initializers with ids in rest elements

    Fix issue 11281. Transform parameters with default initializers that
    have ids that are also in a parameter with a rest element.
    Before, these parameters were not transformed.
    vedantroy committed Mar 24, 2020
    Copy the full SHA
    e842c5d View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    38806e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Remove outdated comment

    vedantroy committed Mar 25, 2020
    Copy the full SHA
    6e1b2d3 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    510040d View commit details
    Browse the repository at this point in the history
  3. Skip when encounter "Scope"

    Previously, f({...R}, f = R => R) would be incorrectly transformed.
    vedantroy committed Mar 25, 2020
    Copy the full SHA
    f8640ec View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    03eedf0 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Address review and re-organize tests

    Checking the RHS of an assignment pattern/checking the parent of
    an identifier node fails on cases like "({...R}, a = f(R))" or
    "({...R}, {[R.key]: a = 42})".
    
    Also refactor tests by removing unecessary tests and
    separating "should transform" from "should not transform" tests.
    vedantroy committed Mar 31, 2020
    Copy the full SHA
    ed4b774 View commit details
    Browse the repository at this point in the history