Don't check type annotations when deciding params scope #11349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Polish 💅
jridgewell
approved these changes
Mar 28, 2020
JLHwung
reviewed
Mar 29, 2020
| @@ -36,6 +36,10 @@ const iifeVisitor = { | |||
| path.stop(); | |||
| } | |||
| }, | |||
| // type annotations don't use or introduce "real" bindings | |||
| "TypeAnnotation|TSTypeAnnotation"(path) { | |||
There was a problem hiding this comment.
Ideally we may expose bindingType of checkLVal to parseBindingList so we do not register bindings of lval when they are inside a type annotation.
BTW we should also skip TSTypeParameters.
function a(b = <T extends (c: any) => void>(): void => {}) {
let c;
}There was a problem hiding this comment.
Since identifiers are the most often created/moved nodes, I think that it would be safer to add a skip like this one to @babel/traverse rather than relying on what was initially parsed.
existentialism
approved these changes
Mar 29, 2020
JLHwung
reviewed
Mar 30, 2020
| let c; | ||
| } | ||
|
|
||
| function d(e = <T>() => {}) { |
There was a problem hiding this comment.
nit: This test will be passing without current change since we are not registering bindings when parsing type parameters.
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type annotations caused unnecessary usage of IIFE, because we checked if they referenced any value binding.