Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add private-property-in-object support #11372

Merged
merged 16 commits into from May 18, 2020
Merged

Add private-property-in-object support #11372

merged 16 commits into from May 18, 2020

Commits on May 9, 2020

  1. Add private-property-in-object support 

    https://github.com/tc39/proposal-private-fields-in-in

The parsing is a little loose, but it's going to take a lot of effor to restrict it to only `in` binary expressions.
    @jridgewell
    jridgewell committed May 9, 2020
    Copy the full SHA
    7cf37fc View commit details
    Browse the repository at this point in the history

  2. Assert PrivateName followed by in keyword

    @jridgewell
    jridgewell committed May 9, 2020
    Copy the full SHA
    7d7c82d View commit details
    Browse the repository at this point in the history

  3. Nit fix

    @jridgewell
    jridgewell committed May 9, 2020
    Copy the full SHA
    beae703 View commit details
    Browse the repository at this point in the history

  4. Update PrivateInExpectedIn message 

    Co-Authored-By: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
    @jridgewell @nicolo-ribaudo
    jridgewell and nicolo-ribaudo committed May 9, 2020
    Copy the full SHA
    ae1aa9c View commit details
    Browse the repository at this point in the history

  5. Only parse if enabled

    @jridgewell
    jridgewell committed May 9, 2020
    Copy the full SHA
    ac3fa34 View commit details
    Browse the repository at this point in the history

  6. Lint

    @jridgewell
    jridgewell committed May 9, 2020
    Copy the full SHA
    9baa3f6 View commit details
    Browse the repository at this point in the history

  7. Update description

    @jridgewell
    jridgewell committed May 9, 2020
    Copy the full SHA
    7c396f9 View commit details
    Browse the repository at this point in the history

  8. Mark undeclared private properties inside in-expressions

    @jridgewell
    jridgewell committed May 9, 2020
    Copy the full SHA
    e423cda View commit details
    Browse the repository at this point in the history

  9. Fix nested private in expressions

    @jridgewell
    jridgewell committed May 9, 2020
    Copy the full SHA
    3f8eb82 View commit details
    Browse the repository at this point in the history

  10. Fix flow type

    @jridgewell
    jridgewell committed May 9, 2020
    Copy the full SHA
    d1a3085 View commit details
    Browse the repository at this point in the history

  11. Fix nested class traversal

    @jridgewell
    jridgewell committed May 9, 2020
    Copy the full SHA
    8c4dbe1 View commit details
    Browse the repository at this point in the history

  12. fix: throw expect privateIn when we see tt._in after private name

    @JLHwung @jridgewell
    JLHwung authored and jridgewell committed May 9, 2020
    Copy the full SHA
    b0dcb2f View commit details
    Browse the repository at this point in the history

  13. update test fixtures

    @JLHwung @jridgewell
    JLHwung authored and jridgewell committed May 9, 2020
    Copy the full SHA
    fc61e67 View commit details
    Browse the repository at this point in the history

  14. nit refactor

    @JLHwung @jridgewell
    JLHwung authored and jridgewell committed May 9, 2020
    Copy the full SHA
    dc90c7e View commit details
    Browse the repository at this point in the history

  15. fix: allow escaped sequence in private in

    @JLHwung @jridgewell
    JLHwung authored and jridgewell committed May 9, 2020
    Copy the full SHA
    a19930f View commit details
    Browse the repository at this point in the history

  16. Flow types...

    @jridgewell
    jridgewell committed May 9, 2020
    Copy the full SHA
    f304cdb View commit details
    Browse the repository at this point in the history