Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add private-property-in-object support #11372
Add private-property-in-object support #11372
Changes from all commits
7cf37fc
7d7c82d
beae703
ae1aa9c
ac3fa34
9baa3f6
7c396f9
e423cda
3f8eb82
d1a3085
8c4dbe1
b0dcb2f
fc61e67
dc90c7e
a19930f
f304cdb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious; do these field WeakMaps have
WeakMap.prototype.has
copied onto them? or can i intercept babel private fields, even in spec mode, by replacingWeakMap.prototype.has
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not secure the weak
maps, so this will do a prototype reference. Note that even
get
andset
calls go through the prototype, too. We can't ensure the order of our evaluation, so theWeakMap
could have already been patched by the time we reach the class definition.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course - you can't protect against first-run code, but to be spec compliant you'd have to at least protect against later code.
Object.defineProperties(id, Object.getOwnPropertyDescriptors(WeakMap.prototype))
atid
creation would address that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, all of our output assumes that builtins haven't been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oof, ok - it's totally fine to assume they haven't been modified at module evaluation time (you don't really have a choice) but it's not fine to assume they haven't been modified later. that should be fixed asap (but not in this PR, obviously)