fix: report missing plugins on type exports #11417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Polish 💅
hzoo
approved these changes
Apr 14, 2020
existentialism
approved these changes
Apr 14, 2020
Co-Authored-By: Brian Ng <bng412@gmail.com>
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR throws more helpful errors on type exports supported by both Flow and TypeScript
It is also considered as a bug fix as type exports should never be considered as exportDefault from clause.
To simplify the parser logic, the current approach does not warn missing flow helpers for the following pedantic case:
which means it will still throw missing
exportDefaultFromplugins though it is a valid type exports. I think this situation still acceptable and practically only those flow codes with such statements as the first one will trigger this issue.