Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make automatic runtime the default for JSX compilation #11436

Merged
merged 1 commit into from Jul 3, 2020
Merged

Make automatic runtime the default for JSX compilation #11436

merged 1 commit into from Jul 3, 2020

Conversation

arku
Copy link
Contributor

@arku arku commented Apr 17, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change? Yes
Minor: New Feature?
Tests Added + Pass?
Documentation PR Link
Any Dependency Changes?
License MIT

Makes the new JSX runtime automatic the default (previously, it was classic).

Refs: #10746, #11154 (comment)

TODOs:

  • Update docs

@arku arku mentioned this pull request Apr 17, 2020
Merged
@arku arku force-pushed the feat/automatic-default-react-jsx-transform-runtime branch 2 times, most recently from f6408aa to 91ff058 Compare April 20, 2020 23:38
@arku arku marked this pull request as ready for review April 20, 2020 23:49
@existentialism existentialism added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release area: react labels Apr 21, 2020
@arku arku force-pushed the feat/automatic-default-react-jsx-transform-runtime branch from 91ff058 to 7e245a4 Compare April 21, 2020 00:18
@arku
Copy link
Contributor Author

arku commented Apr 21, 2020

The fixture tests related to babel-plugin-proposal-dynamic-import are failing. I just submitted a PR to next-8-dev fixing it.

@arku arku force-pushed the feat/automatic-default-react-jsx-transform-runtime branch 2 times, most recently from 200a955 to be54225 Compare April 21, 2020 14:31
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 22, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/24717/

@arku arku force-pushed the feat/automatic-default-react-jsx-transform-runtime branch from be54225 to be58636 Compare May 26, 2020 02:02
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 26, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9007037:

Sandbox Source
wonderful-haslett-bpmvg Configuration
angry-sanderson-8xvll Configuration

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request May 27, 2020
Open
34 tasks
@arku arku force-pushed the feat/automatic-default-react-jsx-transform-runtime branch from be58636 to eb000d0 Compare June 22, 2020 04:54
JLHwung
JLHwung reviewed Jun 24, 2020
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

packages/babel-preset-react/src/index.js Outdated Show resolved Hide resolved
packages/babel-preset-typescript/test/fixtures/jsx-compat/js-valid/output.js Outdated Show resolved Hide resolved
packages/babel-preset-typescript/test/fixtures/jsx-compat/tsx-valid/output.js Outdated Show resolved Hide resolved
@arku arku force-pushed the feat/automatic-default-react-jsx-transform-runtime branch 2 times, most recently from 062c6ca to bb33d08 Compare June 25, 2020 23:53
@arku arku requested a review from JLHwung June 25, 2020 23:56
@JLHwung
Copy link
Contributor

JLHwung commented Jun 26, 2020

@arku I have pushed a fix for the broken CRA e2e test. The e2e test is broken by the nature of this breaking change. Before CRA upgrades @babel/* to version 8, we should patch CRA to pass the e2e test.

@arku arku force-pushed the feat/automatic-default-react-jsx-transform-runtime branch from f8f7571 to d3c726a Compare June 26, 2020 22:15
@arku
Copy link
Contributor Author

arku commented Jun 26, 2020

@JLHwung Thanks for the review and the e2e test fix!

@arku arku force-pushed the feat/automatic-default-react-jsx-transform-runtime branch from d3c726a to 9007037 Compare June 26, 2020 22:27
JLHwung
JLHwung approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks.

arku added a commit to arku/create-react-app that referenced this pull request Jun 26, 2020
@arku
chore: Add runtime option to @babel/preset-react config
0c7c164 
Babel 8 changes the default JSX runtime from classic to automatic.
Since create-react-app does not specify the runtime option,
the e2e tests fail. See babel/babel#11436
and babel/babel#11436 (comment)
for more information.
@arku arku mentioned this pull request Jun 26, 2020
Closed
@JLHwung JLHwung merged commit b31ebbe into babel:next-8-dev Jul 3, 2020
@JLHwung
Copy link
Contributor

JLHwung commented Jul 3, 2020

@arku Can you submit a docs PR?

nicolo-ribaudo pushed a commit that referenced this pull request Jul 5, 2020
@arku @nicolo-ribaudo
Make automatic runtime the default for JSX compilation (#11436)
0ee5335
@JLHwung JLHwung mentioned this pull request Jul 7, 2020
Open
@arku
Copy link
Contributor Author

arku commented Jul 21, 2020

@arku Can you submit a docs PR?

@JLHwung Sure! I'll get to it when I get a chance.

@arku arku deleted the feat/automatic-default-react-jsx-transform-runtime branch July 21, 2020 19:19
@JLHwung
Copy link
Contributor

JLHwung commented Jul 21, 2020

@arku Oh I went ahead and submitted babel/website#2289, can you take a review?

@arku
Copy link
Contributor Author

arku commented Jul 21, 2020

@JLHwung Ah, I see. Thanks!

Let me check.

@arku
Copy link
Contributor Author

arku commented Jul 21, 2020

@arku Oh I went ahead and submitted babel/website#2289, can you take a review?

Done!

nicolo-ribaudo pushed a commit that referenced this pull request Aug 28, 2020
@arku @nicolo-ribaudo
Make automatic runtime the default for JSX compilation (#11436)
f2e0cff
nicolo-ribaudo pushed a commit that referenced this pull request Oct 2, 2020
@arku @nicolo-ribaudo
Make automatic runtime the default for JSX compilation (#11436)
b066f1a
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@nicolo-ribaudo nicolo-ribaudo Awaiting requested review from nicolo-ribaudo

Assignees
No one assigned
Labels
area: react outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release PR: Needs Docs PR: Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@arku @babel-bot @JLHwung @existentialism @nicolo-ribaudo @kaicataldo